From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: patch to commit soon: PR25375 debuginfod prefetching
Date: Tue, 25 Feb 2020 11:32:00 -0000 [thread overview]
Message-ID: <c462f67e934e7f0af52459496d017805a672014b.camel@klomp.org> (raw)
In-Reply-To: <20200224222946.GC26763@redhat.com>
Hi Frank,
On Mon, 2020-02-24 at 17:29 -0500, Frank Ch. Eigler wrote:
> This patch has been baking on my public servers awhile and can make a
> huge difference in performance. It's not something immediately
> obvious how or whether to test, as it's a pure performance improvement.
> Planning to push shortly.
As far as I understand it, it looks good.
One tiny question:
> @@ -2809,7 +2857,8 @@ main (int argc, char *argv[])
> fdcache_mbs = 1024; // 1 gigabyte
> else
> fdcache_mbs = sfs.f_bavail * sfs.f_bsize / 1024 / 1024 / 4; // 25% of free space
> - fdcache_fds = concurrency * 2;
> + fdcache_prefetch = 64; // guesstimate storage is this much less costly than re-decompression
> + fdcache_fds = (concurrency + fdcache_prefetch) * 2;
Here fdcache_prefetch is set and used before argp_parse () is called,
which would set it to the user supplied value (if any). Is that
intentional?
Cheers,
Mark
next prev parent reply other threads:[~2020-02-25 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 22:29 Frank Ch. Eigler
2020-02-25 11:32 ` Mark Wielaard [this message]
2020-02-25 14:49 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c462f67e934e7f0af52459496d017805a672014b.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).