From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: "Érico Nogueira" <ericonr@disroot.org>, libc-alpha@sourceware.org
Cc: elfutils-devel@sourceware.org, Rich Felker <dalias@libc.org>
Subject: Re: [RFC][PATCH] * bits/confname.h: Define _CS_POSIX_V7_THREADS_CFLAGS, _CS_POSIX_V7_THREADS_LDFLAGS
Date: Tue, 8 Mar 2022 13:31:17 -0300 [thread overview]
Message-ID: <c4e41050-5a17-e3e0-fce6-0f42d368bc04@linaro.org> (raw)
In-Reply-To: <d248c832-d814-caab-3105-309bfe38bcc6@linaro.org>
On 08/03/2022 13:29, Adhemerval Zanella wrote:
>
>
> On 26/10/2020 20:33, Érico Nogueira via Libc-alpha wrote:
>> From: Érico Rolim <ericonr@disroot.org>
>>
>> I would like to add these enums in order to conform to the POSIX
>> specification: https://www.man7.org/linux/man-pages/man0/unistd.h.0p.html
>>
>> This change also helps musl-libc, since they want to have these defines
>> with the same values as glibc.
>>
>> I tried to add them for the bits/confname.h and
>> conform/data/unistd.h-data files following the example of the other
>> values, but didn't know how to plug them into the confstr / __sysconf
>> implementations.
>
> I think since we do not export _SC_POSIX_THREADS and now that libpthread
> symbols were all moved to libc, there is no need return the libpthread
> for LDFLAGS. However it requires to be handled on confstr and getconf:
>
> diff --git a/posix/confstr.c b/posix/confstr.c
> index 6e3c264462..95fb0f6abc 100644
> --- a/posix/confstr.c
> +++ b/posix/confstr.c
> @@ -249,6 +249,11 @@ __confstr (int name, char *buf, size_t len)
> /* GNU libc does not require special actions to use LFS functions. */
> break;
>
> + case _CS_POSIX_V7_THREADS_CFLAGS:
> + case _CS_POSIX_V7_THREADS_LDFLAGS:
> + /* GNU libc does not require special actions to use thread functions. */
> + break;
> +
> case _CS_GNU_LIBC_VERSION:
> string = "glibc " VERSION;
> string_len = sizeof ("glibc " VERSION);
> diff --git a/posix/getconf.c b/posix/getconf.c
> index a1adbc4b50..6a5363ad49 100644
> --- a/posix/getconf.c
> +++ b/posix/getconf.c
> @@ -310,6 +310,8 @@ static const struct conf vars[] =
> { "POSIX_V7_LPBIG_OFFBIG_LDFLAGS", _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS, CONFSTR },
> { "POSIX_V7_LPBIG_OFFBIG_LIBS", _CS_POSIX_V7_LPBIG_OFFBIG_LIBS, CONFSTR },
> { "POSIX_V7_LPBIG_OFFBIG_LINTFLAGS", _CS_POSIX_V7_LPBIG_OFFBIG_LINTFLAGS, CONFSTR },
> + { "POSIX_V7_THREADS_CFLAGS", _CS_POSIX_V7_THREADS_CFLAGS, CONFSTR },
> + { "POSIX_V7_THREADS_LDFLAGS", _CS_POSIX_V7_THREADS_LDFLAGS, CONFSTR },
>
> { "_POSIX_ADVISORY_INFO", _SC_ADVISORY_INFO, SYSCONF },
> { "_POSIX_BARRIERS", _SC_BARRIERS, SYSCONF },
>
> Also now that we do not require a copyright assignment, you just need to add
> a sign-off on the email submission.
>
Also, reference the BZ#25003 [1] on title.
https://sourceware.org/bugzilla/show_bug.cgi?id=25003
prev parent reply other threads:[~2022-03-08 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:33 Érico Nogueira
2020-12-21 5:26 ` Siddhesh Poyarekar
2022-03-08 16:29 ` Adhemerval Zanella
2022-03-08 16:31 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e41050-5a17-e3e0-fce6-0f42d368bc04@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=dalias@libc.org \
--cc=elfutils-devel@sourceware.org \
--cc=ericonr@disroot.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).