From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id D187D3857808 for ; Fri, 2 Jul 2021 16:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D187D3857808 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 041933000346; Fri, 2 Jul 2021 18:24:05 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2C061413CE02; Fri, 2 Jul 2021 18:24:05 +0200 (CEST) Message-ID: Subject: Re: patch rfc - valgrind vs. debuginfod From: Mark Wielaard To: "Frank Ch. Eigler" , elfutils-devel@sourceware.org Date: Fri, 02 Jul 2021 18:24:05 +0200 In-Reply-To: <18c1ccc2c44a4212a08a9888556781807e8b8e49.camel@klomp.org> References: <20210617023413.GP3758@redhat.com> <18c1ccc2c44a4212a08a9888556781807e8b8e49.camel@klomp.org> Content-Type: multipart/mixed; boundary="=-lmSfKaL/k6gyA5mpGn6K" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_BADIPHTTP, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 16:24:09 -0000 --=-lmSfKaL/k6gyA5mpGn6K Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Frank, On irc we discussed some issues with trying to disable debuginfod client for valgrind while actually using it in the to be tested executable. The main issue is that valgrind and the test executable are actually one and the same. So disabling or enabling DEBUGINFOD_URLS for one also disables or enables it for the other. So maybe it is just simpler to disable testing under valgrind for those tests that are testing the debuginfod client cache dir directly. That is what the attached patch does. It is pity to not have valgrind run over all the tests, but it is the simplest I could come up with. And this has given us more headaches than we deserve in the first place. What do you think? Thanks, Mark --=-lmSfKaL/k6gyA5mpGn6K Content-Disposition: inline; filename*0=0001-run-debuginfod-find.sh-Disable-valgrind-for-debuginf.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-run-debuginfod-find.sh-Disable-valgrind-for-debuginf.patch"; charset="UTF-8" RnJvbSBhZDNjNTdjZmI2OGQxZWY1ZjZhMWQ0MjY1NzhkODAwNTA0OGMyNTFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFdpZWxhYXJkIDxtYXJrQGtsb21wLm9yZz4KRGF0ZTog RnJpLCAyIEp1bCAyMDIxIDE4OjE2OjAwICswMjAwClN1YmplY3Q6IFtQQVRDSF0gcnVuLWRlYnVn aW5mb2QtZmluZC5zaDogRGlzYWJsZSB2YWxncmluZCBmb3IgZGVidWdpbmZvZAogY2xpZW50IGNh Y2hlIHRlc3RzCgp2YWxncmluZCBpdHNlbGYgbWlnaHQgdXNlIHRoZSBkZWJ1Z2luZm9kIGNsaWVu dC4gU28gZGlzYWJsZSB2YWxncmluZAp3aGVuIHRlc3RpbmcgdGhlIGNhY2hlLgoKU2lnbmVkLW9m Zi1ieTogTWFyayBXaWVsYWFyZCA8bWFya0BrbG9tcC5vcmc+Ci0tLQogdGVzdHMvQ2hhbmdlTG9n ICAgICAgICAgICAgICB8IDUgKysrKysKIHRlc3RzL3J1bi1kZWJ1Z2luZm9kLWZpbmQuc2ggfCA1 ICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS90 ZXN0cy9DaGFuZ2VMb2cgYi90ZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDhmYTk3ZmEuLmEwZTRlYzUy IDEwMDY0NAotLS0gYS90ZXN0cy9DaGFuZ2VMb2cKKysrIGIvdGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsOCBAQAorMjAyMS0wNy0wMiAgTWFyayBXaWVsYWFyZCAgPG1hcmtAa2xvbXAub3JnPgor CisJKiBydW4tZGVidWdpbmZvLWZpbmQuc2g6IHVuc2V0IFZBTEdSSU5EX0NNRCBiZWZvcmUgdGVz dGluZyBkZWJ1Z2luZm9kCisJY2xpZW50IGNhY2hlLgorCiAyMDIxLTA2LTE2ICBGcmFuayBDaC4g RWlnbGVyIDxmY2hlQHJlZGhhdC5jb20+CiAKIAkqIHJ1bi1kZWJ1Z2luZm9kLWZpbmQuc2g6IEZp eCBpbnRlcm1pdHRlbnQgZ3Jvb20vc3RhbGUgZmFpbHVyZSwKZGlmZiAtLWdpdCBhL3Rlc3RzL3J1 bi1kZWJ1Z2luZm9kLWZpbmQuc2ggYi90ZXN0cy9ydW4tZGVidWdpbmZvZC1maW5kLnNoCmluZGV4 IDQ1NmRjMmY4Li43NGE1Y2VmZiAxMDA3NTUKLS0tIGEvdGVzdHMvcnVuLWRlYnVnaW5mb2QtZmlu ZC5zaAorKysgYi90ZXN0cy9ydW4tZGVidWdpbmZvZC1maW5kLnNoCkBAIC01ODMsNiArNTgzLDEx IEBAIGN1cmwgLXMgaHR0cDovLzEyNy4wLjAuMTokUE9SVDIvYnVpbGRpZC9kZWFkYmVlZi9kZWJ1 Z2luZm8gPiAvZGV2L251bGwgfHwgdHJ1ZQogY3VybCAtcyBodHRwOi8vMTI3LjAuMC4xOiRQT1JU Mi9idWlsZGlkL2RlYWRiZWVmL2JhZHR5cGUgPiAvZGV2L251bGwgfHwgdHJ1ZQogKGN1cmwgLXMg aHR0cDovLzEyNy4wLjAuMTokUE9SVDIvbWV0cmljcyB8IGdyZXAgJ2JhZHR5cGUnKSAmJiBmYWxz ZQogCisjIERJU0FCTEUgVkFMR1JJTkQgY2hlY2tpbmcgYmVjYXVzZSB2YWxncmluZCBtaWdodCB1 c2UgZGVidWdpbmZvZCBjbGllbnQKKyMgcmVxdWVzdHMgaXRzZWxmLCBjYXVzaW5nIGNvbmZ1c2lv biBhYm91dCB3aG8gcHV0IHdoYXQgaW4gdGhlIGNhY2hlLgorIyBJdCBzdGF5cyBkaXNhYmxlZCB0 aWxsIHRoZSBlbmQgb2YgdGhpcyB0ZXN0LgordW5zZXQgVkFMR1JJTkRfQ01ECisKICMgQ29uZmly bSB0aGF0IHJldXNlZCBjdXJsIGNvbm5lY3Rpb25zIHN1cnZpdmUgNDA0IGVycm9ycy4KICMgVGhl IHJtJ3MgZm9yY2UgYW4gdW5jYWNoZWQgZmV0Y2gKIHJtIC1mICRERUJVR0lORk9EX0NBQ0hFX1BB VEgvJEJVSUxESUQvZGVidWdpbmZvIC5jbGllbnRfY2FjaGUqLyRCVUlMRElEL2RlYnVnaW5mbwot LSAKMi4xOC40Cgo= --=-lmSfKaL/k6gyA5mpGn6K--