From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69668 invoked by alias); 9 Dec 2019 19:24:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 69204 invoked by uid 89); 9 Dec 2019 19:24:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=images X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2019 19:24:50 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 9F2BA312F0AC; Mon, 9 Dec 2019 20:24:48 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5731242A5E83; Mon, 9 Dec 2019 20:24:48 +0100 (CET) Message-ID: Subject: Re: [PATCH] libdwfl: Find and handle compressed vmlinuz image. From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Aaron Merey , "Frank Ch . Eigler" Date: Mon, 09 Dec 2019 19:24:00 -0000 In-Reply-To: <20191205142131.26624-1-mark@klomp.org> References: <20191205142131.26624-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00248.txt.bz2 On Thu, 2019-12-05 at 15:21 +0100, Mark Wielaard wrote: > Both the dwfl_linux_kernel_find_elf callback and the > dwfl_linux_kernel_report_offline reporting function only handled > vmlinix images possibly compressed with .gz, .bz2 or .xz extension. > They did not find or handle the much more common vmlinuz compressed > images. >=20 > It is not completely clear why we didn't up to now. Support for > compressed ELF files was added in 2009 and the code was updated to > to try to find the .gz, .bz2 or .xz extension variants in 2011. > But not the vmlinuz named variant. Testing (against systemtap) looks good. Pushed to master. Cheers, Mark