From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 989293858D32 for ; Mon, 8 May 2023 16:12:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 989293858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8137030008BB; Mon, 8 May 2023 18:12:06 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 938F834016A; Mon, 8 May 2023 18:12:05 +0200 (CEST) Message-ID: Subject: Re: [PATCH] libdwfl: Fix memory leak in unzip() From: Mark Wielaard To: John Gallagher , elfutils-devel@sourceware.org Date: Mon, 08 May 2023 18:12:05 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi John, On Thu, 2023-04-27 at 23:04 -0700, John Gallagher wrote: > state.input_buffer is not freed if the file is found to not be > compressed with the compression algorithm unzip() is trying to use. Thanks, pushed. It is clearly correct to call fail here. Although in all my tests input_buffer was always NULL. Cheers, Mark