From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: "Érico Nogueira" <ericonr@disroot.org>, libc-alpha@sourceware.org
Cc: elfutils-devel@sourceware.org
Subject: Re: [RFC][PATCH] * bits/confname.h: Define _CS_POSIX_V7_THREADS_CFLAGS, _CS_POSIX_V7_THREADS_LDFLAGS
Date: Mon, 21 Dec 2020 10:56:58 +0530 [thread overview]
Message-ID: <cc25e493-8526-333b-e8c6-9a303be631a4@gotplt.org> (raw)
In-Reply-To: <20201026233303.16034-1-ericonr@disroot.org>
On 10/27/20 5:03 AM, Érico Nogueira via Libc-alpha wrote:
> From: Érico Rolim <ericonr@disroot.org>
>
> I would like to add these enums in order to conform to the POSIX
> specification: https://www.man7.org/linux/man-pages/man0/unistd.h.0p.html
>
> This change also helps musl-libc, since they want to have these defines
> with the same values as glibc.
>
> I tried to add them for the bits/confname.h and
> conform/data/unistd.h-data files following the example of the other
> values, but didn't know how to plug them into the confstr / __sysconf
> implementations.
It's been a while since I touched this code, but IIRC you need to add
your new variables to posix/posix-conf-vars.list.
That said, could you please let me know if you have a copyright
assignment agreement with the FSF? I suppose this change may be OK
given that it is under 20 lines but one of the stewards could confirm
for sure.
Thanks,
Siddhesh
>
> bits/confname.h | 7 ++++++-
> conform/data/unistd.h-data | 2 ++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/bits/confname.h b/bits/confname.h
> index 5dc8215093..fdc5403697 100644
> --- a/bits/confname.h
> +++ b/bits/confname.h
> @@ -670,6 +670,11 @@ enum
>
> _CS_V6_ENV,
> #define _CS_V6_ENV _CS_V6_ENV
> - _CS_V7_ENV
> + _CS_V7_ENV,
> #define _CS_V7_ENV _CS_V7_ENV
> +
> + _CS_POSIX_V7_THREADS_CFLAGS,
> +#define _CS_POSIX_V7_THREADS_CFLAGS _CS_POSIX_V7_THREADS_CFLAGS
> + _CS_POSIX_V7_THREADS_LDFLAGS
> +#define _CS_POSIX_V7_THREADS_LDFLAGS _CS_POSIX_V7_THREADS_LDFLAGS
> };
> diff --git a/conform/data/unistd.h-data b/conform/data/unistd.h-data
> index aa070528e8..6c4b52a733 100644
> --- a/conform/data/unistd.h-data
> +++ b/conform/data/unistd.h-data
> @@ -367,6 +367,8 @@ constant _CS_POSIX_V7_LP64_OFF64_LIBS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_CFLAGS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_LIBS
> +constant _CS_POSIX_V7_THREADS_CFLAGS
> +constant _CS_POSIX_V7_THREADS_LDFLAGS
> constant _CS_POSIX_V7_WIDTH_RESTRICTED_ENVS
> constant _CS_V7_ENV
> # endif
>
next prev parent reply other threads:[~2020-12-21 5:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:33 Érico Nogueira
2020-12-21 5:26 ` Siddhesh Poyarekar [this message]
2022-03-08 16:29 ` Adhemerval Zanella
2022-03-08 16:31 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc25e493-8526-333b-e8c6-9a303be631a4@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=elfutils-devel@sourceware.org \
--cc=ericonr@disroot.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).