From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118756 invoked by alias); 12 Jul 2019 21:49:11 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 118744 invoked by uid 89); 12 Jul 2019 21:49:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jul 2019 21:49:10 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id EE090302BB21; Fri, 12 Jul 2019 23:49:07 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id A2964413CC0E; Fri, 12 Jul 2019 23:49:07 +0200 (CEST) Message-ID: Subject: Re: [[RESEND & PING]PATCH V3 0/1] Add C-SKY support From: Mark Wielaard To: Mao Han , elfutils-devel@sourceware.org Date: Fri, 12 Jul 2019 21:49:00 -0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00047.txt.bz2 On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote: > 5. run-reverse-sections-self.sh > elfcopy --reverse-offs dose not work properly on C-SKY object file, > seems not related to arch specific code. > size.o before copy: > https://github.com/c-sky/test-result/blob/master/elfutils/size.o > size.o.rev after copy: > https://github.com/c-sky/test-result/blob/master/elfutils/size.o.rev This might be because these files are also EM_RCE instead of EM_CSKY. But most likely it was because there was a bug in the testcase. Make sure you have commit d08c68 tests: elfcopy --reverse-offs should only swap sections next to each other. It looks like in the original the .csky.attributes and .shstrtab are not really next to each other (they have consecutive section numbers, but the file offsets are far apart). And that could have fooled the original test case. Please make sure you have the above commit/fix in your tree and see if it passes then. Thanks, Mark