Re: patch 2/2 debuginfod server etc.

[Mark Wielaard <mark@klomp.org>]

Hi Frank,

On Thu, 2019-11-14 at 06:54 -0500, Frank Ch. Eigler wrote:
> > > +++ b/config/debuginfod.sysconfig
> > > +#DEBUGINFOD_VERBOSE="-v"
> > > +DEBUGINFOD_PATHS="/usr/lib/debug /usr/bin /usr/sbin /usr/lib /usr/lib64 /usr/local"
> > 
> > Should this also include /usr/libexec ?
> > Isn't /usr/local too broad? Should it also include /opt and/or /srv?
> 
> Not sure how much it matters.  Added a few of them.  It's not a problem
> to include a path that includes non-elf/dwarf non-rpm files; they'll be
> checked only once.

I see it is now:

DEBUGINFOD_PATHS="/usr/lib/debug /usr/bin /usr/libexec /usr/sbin /usr/lib /usr/lib64 /usr/local /opt"

I think it should only include the default system paths.
Not /usr/local and not /opt, since we don't know what those are used
for.

Also this assumes a setup where all top-level / content moved to /usr
(usrmove) which I think most distros did.

It doesn't cover multi-arch based distros like Debian, where there are
also /usr/lib32 and /usr/lib32x directories.
I don't know what the default for such a system should be.

> > > +%if 0%{?rhel} >= 8 || 0%{?fedora} >= 20
> > > +Recommends: elfutils-debuginfod-client
> > > +%endif
> > > +
> > 
> > Should we add %else Requires: elfutils-debuginfod-client?
> 
> Up to you.  Remember, we made the debuginfod client such that it was
> dlopen'd into libdw(fl) because you didn't want all the
> debuginfod-client (libcurl) required solibs to be loaded into the
> program - or into the minimal elfutils installation footprint.  This
> would undo the latter.

Lets do it. That I want it to be optional doesn't mean I don't want to
see it everywhere possible :)
I'll push it to debuginfod-submit.

Cheers,

Mark