From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130796 invoked by alias); 16 Nov 2019 01:31:00 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 130548 invoked by uid 89); 16 Nov 2019 01:30:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Nov 2019 01:30:52 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1C40B3000275; Sat, 16 Nov 2019 02:30:49 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id CC2A4401EDB5; Sat, 16 Nov 2019 02:30:49 +0100 (CET) Message-ID: Subject: Re: patch 2/2 debuginfod server etc. From: Mark Wielaard To: "Frank Ch. Eigler" Cc: elfutils-devel@sourceware.org, amerey@redhat.com Date: Sat, 16 Nov 2019 01:31:00 -0000 In-Reply-To: <20191114115437.GB873@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <20191028190726.GE14349@redhat.com> <20191114115437.GB873@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00155.txt.bz2 Hi Frank, On Thu, 2019-11-14 at 06:54 -0500, Frank Ch. Eigler wrote: > > > +++ b/config/debuginfod.sysconfig > > > +#DEBUGINFOD_VERBOSE=3D"-v" > > > +DEBUGINFOD_PATHS=3D"/usr/lib/debug /usr/bin /usr/sbin /usr/lib /usr/= lib64 /usr/local" > >=20 > > Should this also include /usr/libexec ? > > Isn't /usr/local too broad? Should it also include /opt and/or /srv? >=20 > Not sure how much it matters. Added a few of them. It's not a problem > to include a path that includes non-elf/dwarf non-rpm files; they'll be > checked only once. I see it is now: DEBUGINFOD_PATHS=3D"/usr/lib/debug /usr/bin /usr/libexec /usr/sbin /usr/lib= /usr/lib64 /usr/local /opt" I think it should only include the default system paths. Not /usr/local and not /opt, since we don't know what those are used for. Also this assumes a setup where all top-level / content moved to /usr (usrmove) which I think most distros did. It doesn't cover multi-arch based distros like Debian, where there are also /usr/lib32 and /usr/lib32x directories. I don't know what the default for such a system should be. > > > +%if 0%{?rhel} >=3D 8 || 0%{?fedora} >=3D 20 > > > +Recommends: elfutils-debuginfod-client > > > +%endif > > > + > >=20 > > Should we add %else Requires: elfutils-debuginfod-client? >=20 > Up to you. Remember, we made the debuginfod client such that it was > dlopen'd into libdw(fl) because you didn't want all the > debuginfod-client (libcurl) required solibs to be loaded into the > program - or into the minimal elfutils installation footprint. This > would undo the latter. Lets do it. That I want it to be optional doesn't mean I don't want to see it everywhere possible :) I'll push it to debuginfod-submit. Cheers, Mark