public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Gavin Li <gavin@matician.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections
Date: Tue, 13 Dec 2022 17:49:49 +0100	[thread overview]
Message-ID: <d2b8b54cc44420f2259d9d1a4437ef63f4e88612.camel@klomp.org> (raw)
In-Reply-To: <CACB127+_44NnDFptSrvvX8c0dmtAL+n8m8JXsCRZgAkuea5v4g@mail.gmail.com>

Hi Gavin,

On Thu, 2022-12-01 at 13:13 -0800, Gavin Li wrote:
> Awesome, thanks for looking over this. I only have one comment:
> there's an extra "xlatefrom.d_size = xlatefrom.d_size;" line that
> should be removed.

Thanks for spotting that. Odd the compiler didn't warn for that. There
is a xlatefrom.d_size = phnum * phentsize; just before this that does
the correct assignment.

Pushed with that line removed.

Cheers,

Mark

      reply	other threads:[~2022-12-13 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  6:26 gavin
2022-11-29 15:25 ` Mark Wielaard
2022-11-29 21:48   ` Gavin Li
2022-11-30 23:14     ` Mark Wielaard
2022-12-01 21:13       ` Gavin Li
2022-12-13 16:49         ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2b8b54cc44420f2259d9d1a4437ef63f4e88612.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=gavin@matician.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).