From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 36A633858C5E for ; Thu, 23 Feb 2023 12:31:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36A633858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8A34C30067D6; Thu, 23 Feb 2023 13:31:20 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id E4C9334025A; Thu, 23 Feb 2023 13:31:19 +0100 (CET) Message-ID: Subject: Re: [PATCH v2 08/16] lib: Implement error properly even when not HAVE_ERR_H From: Mark Wielaard To: Yonggang Luo , elfutils-devel@sourceware.org Date: Thu, 23 Feb 2023 13:31:19 +0100 In-Reply-To: <20221217165213.152-9-luoyonggang@gmail.com> References: <20221217165213.152-1-luoyonggang@gmail.com> <20221217165213.152-9-luoyonggang@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > on win32, there is no err.h See also the discussion around v1 of this patch, I don't believe this is a correct implementation of error. In particular it seems to not print the errno string. https://inbox.sourceware.org/elfutils-devel/dbcc7e30f35097e8d231e6a0a071a08= 8f98a7d48.camel@klomp.org Cheers, Mark