From: Mark Wielaard <mark@klomp.org>
To: Mao Han <han_mao@c-sky.com>, elfutils-devel@sourceware.org
Subject: Re: [[RESEND & PING]PATCH V3 1/1] Add backend support for C-SKY
Date: Wed, 10 Jul 2019 22:11:00 -0000 [thread overview]
Message-ID: <d7f8706bbcde73bd26e41970055ed24a183544c9.camel@klomp.org> (raw)
In-Reply-To: <ede2a66649573ab580c63a6e81c39b0414a8de6c.1559544994.git.han_mao@c-sky.com>
Hi Mao Han,
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> +const char *
> +csky_section_type_name (int type,
> + char *buf __attribute__ ((unused)),
> + size_t len __attribute__ ((unused)))
> +{
> + if (type == SHT_CSKY_ATTRIBUTES)
> + return "CSKY_ATTRIBUTES";
> +
> + return NULL;
> +}
As far as I can see this is like a SHT_GNU_ATTRIBUTES or
SHT_ARM_ATTRIBUTES section. If so, you will also want something like:
diff --git a/src/readelf.c b/src/readelf.c
index cda7c93..8017dc4 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -3571,7 +3571,9 @@ print_attributes (Ebl *ebl, const GElf_Ehdr
*ehdr)
if (shdr == NULL || (shdr->sh_type != SHT_GNU_ATTRIBUTES
&& (shdr->sh_type != SHT_ARM_ATTRIBUTES
- || ehdr->e_machine != EM_ARM)))
+ || ehdr->e_machine != EM_ARM)
+ && (shdr->sh_type != SHT_CSKY_ATTRIBUTES
+ || ehdr->e_machine != EM_CSKY)))
continue;
printf (gettext ("\
And then hook check_object_attribute to display any CSKY specific
attribute names/values.
Cheers,
Mark
next prev parent reply other threads:[~2019-07-10 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 8:17 [[RESEND & PING]PATCH V3 0/1] Add C-SKY support Mao Han
2019-06-03 8:19 ` [[RESEND & PING]PATCH V3 1/1] Add backend support for C-SKY Mao Han
2019-07-10 22:11 ` Mark Wielaard [this message]
2019-07-11 3:20 ` Mao Han
2019-07-14 21:03 ` Mark Wielaard
2019-07-12 22:10 ` Mark Wielaard
2019-07-10 21:33 ` [[RESEND & PING]PATCH V3 0/1] Add C-SKY support Mark Wielaard
2019-07-11 3:13 ` Mao Han
2019-07-11 13:36 ` Mark Wielaard
2019-07-12 11:24 ` Mao Han
2019-07-12 21:20 ` Mark Wielaard
2019-07-12 21:49 ` Mark Wielaard
2019-07-15 8:56 [[RESEND & PING]PATCH V3 1/1] Add backend support for C-SKY Mao Han
2019-07-15 21:44 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f8706bbcde73bd26e41970055ed24a183544c9.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=han_mao@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).