From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id DA6B13858281 for ; Tue, 20 Dec 2022 15:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA6B13858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id D09A830006EE; Tue, 20 Dec 2022 16:10:27 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 98F0F413CD0E; Tue, 20 Dec 2022 16:10:27 +0100 (CET) Message-ID: Subject: Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H From: Mark Wielaard To: luoyonggang@gmail.com Cc: elfutils-devel@sourceware.org Date: Tue, 20 Dec 2022 16:10:27 +0100 In-Reply-To: References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-16-luoyonggang@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,BODY_8BITS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Sat, 2022-12-17 at 05:50 +0800, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang Luo= ) wrote: > On Mon, Dec 12, 2022 at 11:37 PM Mark Wielaard > wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > wrote: > > > on win32, there is no err.h > > > [...] > > > +#else > > > + (void)status; > > > + vfprintf(stderr, format, argp); > > > +#endif > > > va_end(argp); > >=20 > > That doesn't look like a valid implementation of error, it ignores > > errno and doesn't exit when necessary. >=20 > Do you mean it should call `exit(status)` after the error message > is > printed? Yes, if status !=3D 0. Also errno should be printed (as a string). Cheers, Mark