public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Érico Nogueira" <ericonr@disroot.org>,
	"Dmitry V. Levin" <ldv@altlinux.org>
Cc: "Érico Rolim" <erico.erc@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Don't use __BEGIN_DECLS macros from glibc.
Date: Mon, 26 Oct 2020 23:24:45 +0100	[thread overview]
Message-ID: <dc897afee732fbd7323aeaa25943e628b478a3f1.camel@klomp.org> (raw)
In-Reply-To: <C6N595R9UAS1.1YDLF1DJRB651@mussels>

Hi,

On Mon, 2020-10-26 at 18:34 -0300, Érico Nogueira via Elfutils-devel
wrote:
> On Mon Oct 26, 2020 at 8:58 PM -03, Dmitry V. Levin wrote:
> > On Mon, Oct 26, 2020 at 05:44:24PM -0300, Érico Nogueira via
> > Elfutils-devel wrote:
> > > ---
> > >  libelf/elf.h | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > This file is a verbatim copy of glibc's elf/elf.h, see
> > git log -- libelf/elf.h
> > 
> 
> Hm, I see. This change would only make it necessary to restore the top
> and bottom of the file after any update; do you think that would be too
> much trouble? I could also add a comment to make it clear why the
> explicit `extern "C"` is necessary.

Please just suggest a patch upstream to libc-alpha@sourceware.org.
We'll pick it up when they decide to accept it. Note that it is also a
public glibc header installed as /usr/include/elf.h.

Thanks,

Mark

  reply	other threads:[~2020-10-26 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 20:44 Érico Nogueira
2020-10-26 20:58 ` Dmitry V. Levin
2020-10-26 21:34   ` Érico Nogueira
2020-10-26 22:24     ` Mark Wielaard [this message]
2020-10-28 11:46       ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc897afee732fbd7323aeaa25943e628b478a3f1.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=erico.erc@gmail.com \
    --cc=ericonr@disroot.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).