From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 64E3A3857C43 for ; Mon, 26 Oct 2020 22:24:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64E3A3857C43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 3DD7730278CD; Mon, 26 Oct 2020 23:24:45 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2E0024000985; Mon, 26 Oct 2020 23:24:45 +0100 (CET) Message-ID: Subject: Re: [PATCH] Don't use __BEGIN_DECLS macros from glibc. From: Mark Wielaard To: =?ISO-8859-1?Q?=C9rico?= Nogueira , "Dmitry V. Levin" Cc: =?ISO-8859-1?Q?=C9rico?= Rolim , elfutils-devel@sourceware.org Date: Mon, 26 Oct 2020 23:24:45 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 22:24:47 -0000 Hi, On Mon, 2020-10-26 at 18:34 -0300, =C3=89rico Nogueira via Elfutils-devel wrote: > On Mon Oct 26, 2020 at 8:58 PM -03, Dmitry V. Levin wrote: > > On Mon, Oct 26, 2020 at 05:44:24PM -0300, =C3=89rico Nogueira via > > Elfutils-devel wrote: > > > --- > > > libelf/elf.h | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > >=20 > > This file is a verbatim copy of glibc's elf/elf.h, see > > git log -- libelf/elf.h > >=20 >=20 > Hm, I see. This change would only make it necessary to restore the top > and bottom of the file after any update; do you think that would be too > much trouble? I could also add a comment to make it clear why the > explicit `extern "C"` is necessary. Please just suggest a patch upstream to libc-alpha@sourceware.org. We'll pick it up when they decide to accept it. Note that it is also a public glibc header installed as /usr/include/elf.h. Thanks, Mark