From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59815 invoked by alias); 16 Jun 2018 17:58:36 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 59800 invoked by uid 89); 16 Jun 2018 17:58:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*mark, ahead, HX-Exchange-Antispam-Report-CFA-Test:93001095, HX-ClientProxiedBy:300 X-Spam-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx0a-00082601.pphosted.com Received: from mx0a-00082601.pphosted.com (HELO mx0a-00082601.pphosted.com) (67.231.145.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Jun 2018 17:58:33 +0000 Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5GHwTwm012658; Sat, 16 Jun 2018 10:58:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=gvWBWr6xJz9pIkkESrQgBca1vnNpgWsgysTwimG86dU=; b=aY+P1SZ01AINUXQiwq2HXGCvlwoqjKZR8xulr41/pV3xJjW8v8A5qwM93tJdP8QzIj7P 3PKJx38HoWx7bmCX6ZhtoXXS6glQMUlFp0scYRgheSbNUN9Yp0GGUQflie9z4AU70R4D U9AgWOvUDWX3zmgxoKmvRDCvQjW39eaTCUw= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2jmynhrpgf-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 16 Jun 2018 10:58:29 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.33) with Microsoft SMTP Server (TLS) id 14.3.361.1; Sat, 16 Jun 2018 13:58:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gvWBWr6xJz9pIkkESrQgBca1vnNpgWsgysTwimG86dU=; b=hydvGetcNWtS4U/QJ6ayIv+Cxr3UvSerFHIt08R/A8CFUyszSPbsr5EVgbchTNzLng7SevLjnff2wdENbCQ7Phh9lgrcs1KJCR9fC90WfjEFtXiudzc3rJ1J2bZnXhClXvF7CWHEWfaArKYGrBbDIcmByXpstETopGxRh7nYBxI= Received: from macbook-pro-52.dhcp.thefacebook.com (2620:10d:c090:180::1:58f6) by BLUPR15MB0067.namprd15.prod.outlook.com (2a01:111:e400:50ba::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Sat, 16 Jun 2018 17:58:22 +0000 Subject: Re: [PATCH] backends,bpf: add proper relocation support To: Mark Wielaard , , , CC: Richard Henderson References: <20180615224030.2430236-1-yhs@fb.com> <1529157849.12946.113.camel@klomp.org> From: Yonghong Song Message-ID: Date: Sat, 16 Jun 2018 17:58:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1529157849.12946.113.camel@klomp.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c090:180::1:58f6] X-ClientProxiedBy: MWHPR14CA0011.namprd14.prod.outlook.com (2603:10b6:300:ae::21) To BLUPR15MB0067.namprd15.prod.outlook.com (2a01:111:e400:50ba::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 119bd725-1a5f-42eb-b8d2-08d5d3b2c13a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020);SRVR:BLUPR15MB0067; X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0067;3:Om5/gO/hVT9xgN+vNP/k+QXlqwgeIrNwG6iacY26ByrOk0zX2HliCtLPgNi9TzN+rAdy3+QdgDu/tsLgYXUh4wN5H6VVuQvQG+e+jt4+OyPEbie4wkf4TPUYwTHLGtdUsat+ibovbRv2zzPTB8GLI5aRh3IS1bvHa3UB3NF1oR/UfvDUwB3zr8Y9RyorC8wtiWkP11GC6JoWtTBGKE2zc9WbWrpKY4IjpWXyNEMWRN2lg6683ED77PCVGbb62Dk8;25:ZGzbJ53k4bJKA8Kqm9ns6+aSwTJvgaq9wu+S06rRgXKUcapY/hnitEQlogv1H8j3by/pxlxAOhXC2WwpJC2vacy01y4AUZDQbEcCJVGnV16DgH4RS7uNp13NvcOJxmPbehg40pwFXmlTJ19KLH3WJ8cLt8cQiZwnHmXqziPfI0dXpEGFs1qhV3nD0Wc1RrWJEW3NWTK2iSKOPUpGsbbmcunwrDO3/M8cnsO6JlWVOR0ud1x4fblTiLhZgT4b4TFyYu6uKCAlA3ylQJaOCpJA4VWZxzkcs1ler95peH94zctq6iaViaF8BXrOzJus0xHquZfEu40+0p0dTkhKJcfGxA==;31:DZqPc9SnmqffqTMCN4E7WrcRlAF+r5PK5OjZAY4K2iWWgBfOhNp4Bvqzkm5wrg2yIqfiEq8+k8xFzKUwlOghxERq3sRzgNU5OHBStZ6bLxk6a5F9Gthh4oMRFUx7kehI8LKTXPy27J5W80GaITw7W2cMpGIpWlnirQKFe8mVP603gU549RVN2RGY8TQAN4/qCXjv8QXS8RdcDbPyinyjpJ7P7w7Amh1nQzRJVTGlZgs= X-MS-TrafficTypeDiagnostic: BLUPR15MB0067: X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0067;20:oabmaaspD3T2AIBOZ8/WF59vfzwyWTYIytFU+8m/exfWPqfbhxtsho6bBmOSzBQFLtAfjuXrlKwSCtGypiGd1GBWx8plVI4S/YlKWwJd0ATVVIiVYEHfAVUQK1EEfp8EVo5WS7pnX8T8gBNRvFdH5zdzaKp8NKsAXD9+ConctMxP0cIUPahE/rm/mdMKKhngrD5fbE/jTgVa0f2WsNdAPMOWFNZvldK4qIRTflhyAIJHVKKJ4jQI/KX3Fc2kSd+kbbn0zBAzQ7OvOOrMD5C6MqOlZerkgkqlHxUl2jByJZBh3xh5PRGFJRQKpKXjkRsFnHcxU+zE0Qhtt/KJGtjc05k1iBpCK/FZQm+rA/qpwsnooc/F9/ShlooI+1GDNLFO2TWJE2AiMIShy2MaTk2uqdMz40qSDbl2jvbNkOln2YOiaJqcblRAuHcGsMqbOsP5yDYXsL1muPI+JknIrzPiVECjGmElxABoMmRcpG8Ycr4FsF1InXRbh42Els3JDPj4;4:bVh9Fj6VbRU22Cv4mEirV1RZVP5J1MDMyHGVNAM+zWmulc1g9W3AebRUw7AfA6OOHENH771VpxchS8riwCbb6O7bkz57fOLoSAfdl9lHdcgQULx3+gl8bo2W1sFT5xavha3udJ1cNi0hn2aWteVfDI7klP/qL4wQAqs8HkvemORWqqR3ZopjpMWj1xbIpRiDYFdb3W23cfn99h9Cq/xsNBXUCj0ze+XQp6/MryaCY2YDxpRnPc2OpHlo/VgU4c28cS5UY2lkflaPQ0bmpClqOAPza0+Ti0nsvYx+VQsLSrbKiMN8/XzPjNe1HSxcAKoWus8HTRIetAAwM0pgkYN2XOAwTZNrPLF6c5DiqhxzYtF3txcC2GBbV2dncDfP2pEYaXpn+R8i96F2ZjP9byql2jzCYDi4qxDuRM1rnei1HvU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(10436049006162)(67672495146484)(262104967686372)(5213294742642); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231254)(11241501184)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:BLUPR15MB0067;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0067; X-Forefront-PRVS: 0705EB1700 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(366004)(39380400002)(396003)(376002)(39860400002)(346002)(54534003)(199004)(189003)(4326008)(31686004)(47776003)(6486002)(476003)(46003)(486006)(2616005)(65806001)(11346002)(446003)(65956001)(6116002)(6666003)(478600001)(6636002)(65826007)(106356001)(229853002)(5660300001)(105586002)(68736007)(50466002)(6246003)(86362001)(575784001)(23676004)(31696002)(81166006)(59450400001)(81156014)(53546011)(386003)(52146003)(2486003)(305945005)(36756003)(8936002)(25786009)(8676002)(52116002)(16526019)(6506007)(7736002)(64126003)(186003)(52396003)(58126008)(316002)(97736004)(6512007)(2870700001)(53936002)(67846002)(6306002)(76176011)(2906002)(142933001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR15MB0067;H:macbook-pro-52.dhcp.thefacebook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjE1TUIwMDY3OzIzOlB2bDd4MUMyZ3o0eTVZd3JaSnpTNlBqZEFh?= =?utf-8?B?K1Z4MFF0cm1LRFhwbitIS3Y2OUlDUE5mM3gwZXU4MjhnWS9DSit1OWt1RmtH?= =?utf-8?B?b1UrWHErMExWc3FVTEg2bVhIOUpCUFArTzE0S3h0c0FpY05kSGxmamhuZjRs?= =?utf-8?B?Z3ZyalZqTkIvcjYySUFhWEhYQVd2SXp3ajJsd3laMHBEUXlHWnp1eVI0eDY2?= =?utf-8?B?ZUJkNTlIV2hZdHdUZnhhWkJkMHZ6M3FVZzR1Mk9UMlRyMTk2clAzT2xqNjFn?= =?utf-8?B?T1Z1ckUrZG1kNDh6MlBFTlRjZDdzU1o4OUg2VlZ3NGp0a0FmWnh4UHBabGRz?= =?utf-8?B?T21HcnZKQzB4MXEvOEYwdlExTGRCbWZsVEpwNGxsNUYrV2NKWGZtU0hPSmhG?= =?utf-8?B?N0dxTDUxTFNFdWQ5U21OSjJRblZjRWVWVVpNc3paOGQ1WGVvd0JreWVzNVh2?= =?utf-8?B?VEpSMXBZTFhTcXBVZXltcHFUb0xYampuUWRib3VCKzl6UmdhR0tyY0hZdG9y?= =?utf-8?B?WDArU0YzZjJCZmdQMzFpSHZ3S3J5dCtiQmIzUzBlaHpQdnlmUjVqOUJBVXdr?= =?utf-8?B?OEtqajZNSlo1cXZ5SHJBZjBhNTMzRzlSdzM4U3BhWDJCQ092b01NOSsxYTRk?= =?utf-8?B?L2tENktFVUJNV0NmSFNBSWgrSlF4dWlud29CaE5nMTNpNWlCZ0dmYmJVSG1G?= =?utf-8?B?TnczL0Z2UzJHY0NBN01RMjhCei9TY21NMzFONDMzaFNPZHJSenJObEtlNnN1?= =?utf-8?B?UnR1cklWVFNyMHRDN2cvS0tiMTR2UjgzVHRPY2JranI5VDVHUys4YW9pcnZr?= =?utf-8?B?aldxNTVPcTVaRVpMNEVleTQ0YzlvZnJudDcxQS9aNXlueGIxTko0di91VzAx?= =?utf-8?B?ODluUXJ4UnQ4UWpyTEppekFNdE55RythRHlKb0FOWmdrVGhCYWYxNHV3UTlD?= =?utf-8?B?ZlRZb3RTQmsvZWx0bkV5NWQ4ZUx4b1IvU0ZkZ0xtQkFDUXI3aXcveGZlMCt0?= =?utf-8?B?NlgzUHJVdGJVMnNZU3FvQVVEV1JXcmM2TitHSERPUUJXclAyUUw5NTVKeXpj?= =?utf-8?B?SXhXaFJ4YXRIaVM0MFVWMVJhdHd3TFpFRzRwSmFYVXBnSVJldFhYOE5Dakp3?= =?utf-8?B?ckpueWdrTTZLbjRrTUxMS1VMcWhkcHpuUWs1TmR0M2YvWVZjbkxXNTFNV2pq?= =?utf-8?B?R3NBcWNrMG9vZHJBWEVzQWhIL2dscEwzdnFzUFI4Z2VWM0Z1OFhQUW1CTXN1?= =?utf-8?B?UFRFRXplMzUyN1U1TlBBSURXd0E4ZzA5YzA0TndVSXU5TDV1QlU3K2dWVGVE?= =?utf-8?B?T3NWK1JZVDZqNTlRQ2RhandJdUlrSHI4K25SWDhOdkUrTEV0TUtNNGFqWTFj?= =?utf-8?B?WE90U0habXlsRjFFQzFudlp0a0laU3lDMWFIeHdDd25yZFR0Rll0M29VVW9K?= =?utf-8?B?V04vNHFuN21vN0Q1M1ZSNjc1UElPSnRNUnVtY3pYUjZmUSt2VDYxbHdkakt2?= =?utf-8?B?ZEIveHNxOTBmMFdkN2xad3lweFZzVmNxRTRqaGtoTndoQXNPR1prcWY3eXlY?= =?utf-8?B?TTNEREE0KzdwMHdONnhwL3A5ZUNpNkJpRWdvNmNiM1ZYV2hDSEx1eDFsYUpN?= =?utf-8?B?Uk1uV3M2Zm5yUEEyVGpwcDVPbHRvOGZCL1VLb0lLT0M3RU9sMUZQY3pGVVpk?= =?utf-8?B?TVNRUWQrcitCTnN5U29Wcis5c21pU1N1WmtUV2RCWStLdXQrVlpSdW9DVWdh?= =?utf-8?B?Qkc2eTNrVW83eXpOMDRjNlJXa2lLc0JWL1FTTEZiaUVoSkFwc0ppMnJyZmlH?= =?utf-8?B?SWJORlR5K2tHUzBqVXNiL0xxV25jUFhMV1JtaTlzSXlIRVJlekxRcW1leFph?= =?utf-8?B?V3ZzYWlaSzM2Q2NLbEhuQTBML09iM3ZmTzJMN0ZUYm5MQXJnaWhIRlZNM0Vr?= =?utf-8?B?K1lyemdqNTF1TW1PYTBCSm94UnBxRGdCeFl5VEdtVm9pMEc1Z0Zmc2dHanpX?= =?utf-8?B?VklLOUFOMlZHR0I4K0xHOHN0aGJ6LzlSQ214dDB1Y05uNlAvWTJmdmFtbElX?= =?utf-8?Q?QPd0=3D?= X-Microsoft-Antispam-Message-Info: PEbE3lnuenz9tSA/ONWATSkidhZKMK0jwoX5L3PUYDaUl7j0tptbeM1+Dwm75eoJFjPxTvrsr6McmheP2Qw7m7Ez7fv451vhCPyQmEIBDS6FsEJEpWDGB07DsD0urrewzPD0ysqW5T4geFjgv6BjofAppZAhiNmxrd2o7lTNGMFUXGf31CL7VjZYd3VipBmH X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0067;6:qa3M6kIW5/5v89+tJC0iUfbaxy5niOJXapm/FQwfh2IKGC1zFKwNQNGw0NRnyoQVw8qVboAYo4q4hDcqE1QekWf6Cuv11hR2ZknEDMN4mgb91onztLZjeofppX52qvw2K7OHHJTb/FRGiLCGQ2BawSLGYkzpEELlIH6rHXKreZEXKafR6BjvZGkkYM9BplPsWFyp/SercjN40DiMidO+b2zFXmnjS36HUoU5wdaalaHEnTOFSD6F8cEhMB13H1bGb/5GUhKHMDQImMav1U6Oh+Mmc9NtugadAfzGr7ZwhbRw+LNvXEzDM00jqtb17xkNeZWlNpRxLSBoQ8nB9WxkqCH/Gt4Al2mKif9SRXCgdmH32uJjQzFFIhZ+RKi4cUujn9fhc2Y/qDJJHfiLFyiVUaPfwoi3N7kUG6RphWGCCQKTcirVmOalGwBS1MGS+V/GYWclHwCMBf+5QTXb76YDQA==;5:/W2U53l/0r2VGH/4Y8Lff6Rb0o2khLYcCzSnVL8pGOsCBQx28TgXX090jxCcWYzoiTm6KIKH96lTRXZvbRB4Y4/yB/D8hx5j/W37rP7rZ6u8S27rhyxCt90Yg7xL6ncIWNvU1SVCyQUP0AghRjO1EYyWduzuc5jJEYNoDvA4uS4=;24:4jbLgDdDxLJJimzl9bSn9HBueYPpiGygS3Z+F1XhPcYJFW+Hsh2+KeCZWsREffOjYZSYsDaVg45WbxQx3QF8w6X7WNAcv0Nty66IbS7+3aE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0067;7:0jP2obHhmUG6UUuY1BJQwS3LWO+5ATILZXpl038j3N/9ahMHhNOyYWXq33ztfaUzZLIeb7kJNb2NAQcqBmGv9CkG6WE6IRfps7DiBNSt2G8RQKbWHbkSvfzNZuxfKIyVO9w7ntdYsczjbvBgW9JBYgP6U0LmLlQ0nUoAAn11Rcd9yH2MiFArQC2DvcWeiQPR8PXEMnZrFsXnV7bGH2R8GuLpA0Y0xVWS9PkPW9UOhMoV21SDUz4xoyoOEDuFSfIU;20:hR73nSkdd+r6/RP3Yg/XyGT/LGb5JQ8U3AKESeppjTuETWUbO6uu09HAtdJw6bj9hOdPaeXiDwF9WDMu006sQsxMbFpgi1DlXwEgKEY3A8Bj8cJIZN+gcZgcrss7QRBmoVLN9ycImjYIey40uz1KV16n7lmY831T0P8BaS3V+EQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2018 17:58:22.4910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 119bd725-1a5f-42eb-b8d2-08d5d3b2c13a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR15MB0067 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-16_09:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-SW-Source: 2018-q2/txt/msg00222.txt.bz2 On 6/16/18 7:04 AM, Mark Wielaard wrote: > Hi, > > I added Richard to the CC, who added the original BPF support. > Who might remember where the R_BPF_MAP_FD comes from (see at the end). > > On Fri, 2018-06-15 at 15:40 -0700, Yonghong Song wrote: >> Due to libdw does not have proper BPF relocation support, >> the pahole cannot display filenames correctly for objects >> with default llvm options. So we have to invent >> a special option "llc -march=bpf -mattr=dwarfris" to >> prevent llvm from generating cross-section dwarf relocation >> records (https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_rL326505&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=reaovSjSH40LhrR6vohT7wIrLEVKTNdKYsXxw2wN0hM&s=_1Zapq0e2D1JVvkHQ6roxhWYP307V4tveppbAo2yTpc&e=). >> The pahole related discussion is in linux netdev >> mailing list (https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openwall.net_netdev_2018_06_15_38&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=reaovSjSH40LhrR6vohT7wIrLEVKTNdKYsXxw2wN0hM&s=OJqgsG_v099f9jVBOq7h0SpxOSySbSy3Pcf7_XgIRG0&e=, etc.) >> >> We would like to add proper BPF relocation support >> to libdw so eventually we could retire the special llc bpf >> flag "-mattr=dwarfris". > > Yes. elfutils/libdwfl only does "simple relocations", but that is all > you need anyway. That is correct. > > Do you have a test file (binary for something simple/trivial generated > by llc -march=bpf that contains at least one reloc). I looked at your > implementation and I am sure it works correctly. But having a small > testfile is always a plus. Okay let me create a test case and submit the patch again. >> The bpf relocations are defined in >> llvm_repo:include/llvm/BinaryFormat/ELFRelocs/BPF.def: >>   ELF_RELOC(R_BPF_NONE,        0) >>   ELF_RELOC(R_BPF_64_64,       1) >>   ELF_RELOC(R_BPF_64_32,      10) >> >> Removed the relocation type R_BPF_MAP_FD whoes name does not >> confirm to llvm definition and replaced it with R_BPF_64_64. >> The BPF object is just a relocatible object, not an executable or >> a shared library, so assign ELF type to REL only in bpf_reloc.def. >> >> Tested locally with building pahole with this patch and >> pahole is able to display structures in bpf object file properly. > > Patch looks good. Thanks. I'll add a ChangeLog entry because that is > what we still do. Sure. > >> Signed-off-by: Yonghong Song >> --- >>  backends/Makefile.am   |  2 +- >>  backends/bpf_init.c    |  1 + >>  backends/bpf_reloc.def |  3 ++- >>  backends/bpf_symbol.c  | 54 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>  libelf/elf.h           |  3 ++- >>  5 files changed, 60 insertions(+), 3 deletions(-) >>  create mode 100644 backends/bpf_symbol.c >> [...] >> diff --git a/libelf/elf.h b/libelf/elf.h >> index f7748983..940e88dd 100644 >> --- a/libelf/elf.h >> +++ b/libelf/elf.h >> @@ -3848,7 +3848,8 @@ enum >>  /* BPF specific declarations.  */ >> >>  #define R_BPF_NONE 0 /* No reloc */ >> -#define R_BPF_MAP_FD 1 /* Map fd to pointer */ >> +#define R_BPF_64_64 1 >> +#define R_BPF_64_32 10 > > We should sync this with glibc. This file really is a copy of elf/elf.h > in glibc, which we periodically sync. It would be good if all projects > agree on the constants. > > I would like to understand where the R_BPF_MAP_FD comes from. But I > assume it was a typo for BPF_PSEUDO_MAP_FD from bpf.h (which has the > same constant number 1). > > I'll sent a patch to libc-alpha@sourceware.org unless you beat me to > it. Please go ahead to submit the necessary elf.h changes to libc. Thanks! > > Thanks, > > Mark >