From: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
To: Mark Wielaard <mark@klomp.org>
Cc: "elfutils-devel@sourceware.org" <elfutils-devel@sourceware.org>,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
Subject: Re: [PATCH] Add support for ARCv2
Date: Mon, 31 Oct 2022 14:54:33 +0000 [thread overview]
Message-ID: <decb58d9-225c-bd67-ce28-49f37aa13c34@synopsys.com> (raw)
In-Reply-To: <Y13Tk6e/qsoolka+@wildebeest.org>
Hi Mark,
Thank you for response. First and foremost, there is a second iteration of the
patch [1]. I don't want you, or anybody else, waste time looking into v1. The
changes from v1 have been mentioned at the end of v2 commit message.
[1]
https://sourceware.org/pipermail/elfutils-devel/2022q4/005543.html
Regarding your concerns, please find my answers below.
On 10/30/22 02:29, Mark Wielaard wrote:
> On Fri, Oct 28, 2022 at 01:43:49PM +0000, Shahab Vahedi via Elfutils-devel wrote:
>> This adds support for Synopsys ARCv2 processors.
>
> Is there an easy way to this this (is there a qemu target or a machine
> in the gcc compile farm)?
There is a QEMU target [2]. However, this patch adds a minimal support for ARC.
I'm not quite sure building and running elfutils natively for ARC would test
much at this point. That's why I tested with an x86_64 build with ARC target
support: master + patch -> make check
Unfortunately, there is no machine in GCC's compile farm. There does exist a
pre-built compiler [3] and a repo [4] though.
[2]
https://github.com/foss-for-synopsys-dwc-arc-processors/qemu
[3]
https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/tag/arc-2021.09-release
[4]
https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/tree/arc-2021.09
>> ARC target related
>> macros has been added to libelf/elf.h. However, there a few changes
>> on existing ARC macros to correct them and be in sync with binutils.
>
> We normally sync with the glibc elf.h, have you submitted these
> changes to libc-alpha?
No, but I intend to. In a v2 of the patch [1], I also have added ChangeLog
entries. It must be easier now to quickly figure out what has changed and
if it's OK or not.
>> There are no regressions in tests for an x86_64 build.
>>
>> ==========================================
>> elfutils 0.187: tests/test-suite.log
>> ==========================================
>>
>> .. contents:: :depth: 2
>>
>> FAIL: run-backtrace-native-core.sh
>> ==================================
>>
>> backtrace: No modules recognized in core file
>> backtrace-child-core.8740: no main
>> rmdir: failed to remove 'test-8732': Directory not empty
>> FAIL run-backtrace-native-core.sh (exit status: 1)
>>
>> FAIL: run-backtrace-native-core-biarch.sh
>> =========================================
>>
>> backtrace: No modules recognized in core file
>> backtrace-child-biarch-core.8763: no main
>> rmdir: failed to remove 'test-8755': Directory not empty
>> FAIL run-backtrace-native-core-biarch.sh (exit status: 1)
>
> These two need abi_cfi hooks to describe the DWARF CFI needed to
> unwind.
To be clear, these are the test results on a build without the patch AND
with the patch. I'm not sure why it happens even without the patch on
my system. If you want, I can file a bug report with more details.
--
Shahab
next prev parent reply other threads:[~2022-10-31 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 13:43 Shahab Vahedi
2022-10-31 14:52 ` [PATCH v2] " Shahab Vahedi
[not found] ` <Y13Tk6e/qsoolka+@wildebeest.org>
2022-10-31 14:54 ` Shahab Vahedi [this message]
2022-11-01 21:01 ` [PATCH] " Mark Wielaard
2022-11-09 16:33 ` Shahab Vahedi
2022-11-30 8:15 ` Shahab Vahedi
2022-11-30 23:36 ` Mark Wielaard
2022-12-01 9:44 ` Shahab Vahedi
2022-12-13 14:05 ` Mark Wielaard
2022-12-15 8:49 ` Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decb58d9-225c-bd67-ce28-49f37aa13c34@synopsys.com \
--to=shahab.vahedi@synopsys.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).