public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] Add -Wtrampolines to CFLAGS.
Date: Wed, 21 Nov 2018 12:12:00 -0000	[thread overview]
Message-ID: <e2ae38e7f6b109b2cb4a494d7b916d9224c21b30.camel@klomp.org> (raw)
In-Reply-To: <1542624854-9837-1-git-send-email-mark@klomp.org>

On Mon, 2018-11-19 at 11:54 +0100, Mark Wielaard wrote:
> elfutils uses nested functions a lot. This is fine unless one takes
> the
> address of such a nested function. When taking the address of a
> nested
> function a trampoline is generated that on some systems require the
> stack
> to be executable. That is bad. We never want to generate such
> trampolines.
> Add -Wtrampolines to CLAGS to make sure we don't.

Pushed to master.

      reply	other threads:[~2018-11-21 12:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 10:54 Mark Wielaard
2018-11-21 12:12 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2ae38e7f6b109b2cb4a494d7b916d9224c21b30.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).