From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42589 invoked by alias); 21 Nov 2018 12:12:54 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 42563 invoked by uid 89); 21 Nov 2018 12:12:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Nov 2018 12:12:51 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B0FE8300B2F0 for ; Wed, 21 Nov 2018 13:12:49 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id ABE504000706; Wed, 21 Nov 2018 13:12:49 +0100 (CET) Message-ID: Subject: Re: [PATCH] Add -Wtrampolines to CFLAGS. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Wed, 21 Nov 2018 12:12:00 -0000 In-Reply-To: <1542624854-9837-1-git-send-email-mark@klomp.org> References: <1542624854-9837-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00157.txt.bz2 On Mon, 2018-11-19 at 11:54 +0100, Mark Wielaard wrote: > elfutils uses nested functions a lot. This is fine unless one takes > the > address of such a nested function. When taking the address of a > nested > function a trampoline is generated that on some systems require the > stack > to be executable. That is bad. We never want to generate such > trampolines. > Add -Wtrampolines to CLAGS to make sure we don't. Pushed to master.