From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 3D32F3858D39 for ; Wed, 8 Feb 2023 16:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D32F3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 0C7EA30067CA; Wed, 8 Feb 2023 17:52:53 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 399A13402C2; Wed, 8 Feb 2023 17:52:52 +0100 (CET) Message-ID: Subject: Re: [PATCH RFC 04/11] readelf: Fix set but not used parameter From: Mark Wielaard To: Ilya Leoshkevich , elfutils-devel@sourceware.org Date: Wed, 08 Feb 2023 17:52:51 +0100 In-Reply-To: <20230206222513.1773039-5-iii@linux.ibm.com> References: <20230206222513.1773039-1-iii@linux.ibm.com> <20230206222513.1773039-5-iii@linux.ibm.com> Content-Type: multipart/mixed; boundary="=-88kMZDAvHQ+7jzecakDa" User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-88kMZDAvHQ+7jzecakDa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ilya, On Mon, 2023-02-06 at 23:25 +0100, Ilya Leoshkevich via Elfutils-devel wrote: > clang complains: >=20 > readelf.c:12205:72: error: parameter 'desc' set but not used [-Werror= ,-Wunused-but-set-parameter] > handle_bit_registers (const Ebl_Register_Location *regloc, const void= *desc, > = ^ >=20 > Apparently handle_bit_registers() is unimplemented, but one line is > still written for the future. Silence the warning by casting desc to > void. Someone else also noticed this and filed a bug report, could you add the bug URL to the commit message? https://sourceware.org/bugzilla/show_bug.cgi?id=3D30084 Also can we just remove this whole function? It is never really used since as far as I can see we don't have any backend with a core register sets where a register doesn't have a number of bits which isn't a multiple of 8 (only ia64 has some 1 bit registers, but those don't seem part of the core register set). If we do accidentally try to handle such a register having an abort is also not very nice. Lets just warn and return/continue. Something like the attached? Thanks, Mark --=-88kMZDAvHQ+7jzecakDa Content-Disposition: inline; filename="p" Content-Type: text/x-patch; name="p"; charset="UTF-8" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9yZWFkZWxmLmMgYi9zcmMvcmVhZGVsZi5jCmluZGV4IDUxYjBlOGI5 Li41MGJmZDFjOCAxMDA2NDQKLS0tIGEvc3JjL3JlYWRlbGYuYworKysgYi9zcmMvcmVhZGVsZi5j CkBAIC0xMjIwMSwyNCArMTIyMDEsMTcgQEAgaGFuZGxlX2NvcmVfaXRlbXMgKEVsZiAqY29yZSwg Y29uc3Qgdm9pZCAqZGVzYywgc2l6ZV90IGRlc2NzeiwKICAgcmV0dXJuIGNvbG5vOwogfQogCi1z dGF0aWMgdW5zaWduZWQgaW50Ci1oYW5kbGVfYml0X3JlZ2lzdGVycyAoY29uc3QgRWJsX1JlZ2lz dGVyX0xvY2F0aW9uICpyZWdsb2MsIGNvbnN0IHZvaWQgKmRlc2MsCi0JCSAgICAgIHVuc2lnbmVk IGludCBjb2xubykKLXsKLSAgZGVzYyArPSByZWdsb2MtPm9mZnNldDsKLQotICBhYm9ydCAoKTsJ CQkvKiBYWFggKi8KLSAgcmV0dXJuIGNvbG5vOwotfQotCi0KIHN0YXRpYyB1bnNpZ25lZCBpbnQK IGhhbmRsZV9jb3JlX3JlZ2lzdGVyIChFYmwgKmVibCwgRWxmICpjb3JlLCBpbnQgbWF4cmVnbmFt ZSwKIAkJICAgICAgY29uc3QgRWJsX1JlZ2lzdGVyX0xvY2F0aW9uICpyZWdsb2MsIGNvbnN0IHZv aWQgKmRlc2MsCiAJCSAgICAgIHVuc2lnbmVkIGludCBjb2xubykKIHsKICAgaWYgKHJlZ2xvYy0+ Yml0cyAlIDggIT0gMCkKLSAgICByZXR1cm4gaGFuZGxlX2JpdF9yZWdpc3RlcnMgKHJlZ2xvYywg ZGVzYywgY29sbm8pOworICAgIHsKKyAgICAgIGVycm9yICgwLCAwLCAiV2FybmluZzogQ2Fubm90 IGhhbmRsZSByZWdpc3RlciB3aXRoICUiIFBSSXU4ICJiaXRzXG4iLAorCSAgICAgcmVnbG9jLT5i aXRzKTsKKyAgICAgIHJldHVybiBjb2xubzsKKyAgICB9CiAKICAgZGVzYyArPSByZWdsb2MtPm9m ZnNldDsKIAo= --=-88kMZDAvHQ+7jzecakDa--