public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] libebl: consistently use _(Str) instead of gettext(Str)
Date: Wed, 16 Dec 2020 15:09:14 +0100	[thread overview]
Message-ID: <e67d99a167e20cd0262ecbcd0d63b0a45a1aa2cc.camel@klomp.org> (raw)
In-Reply-To: <20201216014759.GA21292@altlinux.org>

Hi Dmitry,

On Wed, 2020-12-16 at 04:48 +0300, Dmitry V. Levin wrote:
> libeblP.h defines _(Str) to dgettext ("elfutils", Str) instead of
> a simple gettext (Str) for a reason: the library might be indirectly
> used by clients that called bindtextdomain with a domain different
> from "elfutils".

This, and the other gettext -> _ changes look OK.
For the src tools it is probably unnecessary, but good for consistency.
Please push.

Thanks,

Mark

      parent reply	other threads:[~2020-12-16 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  1:48 Dmitry V. Levin
2020-12-16  9:54 ` [PATCH 1/4] Consistently define _(Str) using dgettext ("elfutils", Str) Dmitry V. Levin
2020-12-16  9:54 ` [PATCH 2/4] lib: consistently use _(Str) instead of gettext(Str) Dmitry V. Levin
2020-12-16  9:54 ` [PATCH 3/4] libcpu: " Dmitry V. Levin
2020-12-16  9:54 ` [PATCH 4/4] src: " Dmitry V. Levin
2020-12-16 14:09 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e67d99a167e20cd0262ecbcd0d63b0a45a1aa2cc.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).