From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id F20C738708E1
 for <elfutils-devel@sourceware.org>; Wed, 16 Dec 2020 14:09:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F20C738708E1
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 7DF9337251C7;
 Wed, 16 Dec 2020 15:09:14 +0100 (CET)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 6A14240006CA; Wed, 16 Dec 2020 15:09:14 +0100 (CET)
Message-ID: <e67d99a167e20cd0262ecbcd0d63b0a45a1aa2cc.camel@klomp.org>
Subject: Re: [PATCH] libebl: consistently use _(Str) instead of gettext(Str)
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, elfutils-devel@sourceware.org
Date: Wed, 16 Dec 2020 15:09:14 +0100
In-Reply-To: <20201216014759.GA21292@altlinux.org>
References: <20201216014759.GA21292@altlinux.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2020 14:09:17 -0000

Hi Dmitry,

On Wed, 2020-12-16 at 04:48 +0300, Dmitry V. Levin wrote:
> libeblP.h defines _(Str) to dgettext ("elfutils", Str) instead of
> a simple gettext (Str) for a reason: the library might be indirectly
> used by clients that called bindtextdomain with a domain different
> from "elfutils".

This, and the other gettext -> _ changes look OK.
For the src tools it is probably unnecessary, but good for consistency.
Please push.

Thanks,

Mark