From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8523 invoked by alias); 4 Nov 2019 16:19:56 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 8415 invoked by uid 89); 4 Nov 2019 16:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=H*F:U*mark, 20191025 X-Spam-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 16:19:53 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 24107300047E; Mon, 4 Nov 2019 17:19:49 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 3EF4A4970339; Mon, 4 Nov 2019 17:19:49 +0100 (CET) Message-ID: Subject: Re: [PATCH 3/3] lib + libdw: Add and use a concurrent version of the dynamic-size hash table. From: Mark Wielaard To: Jonathon Anderson Cc: elfutils-devel@sourceware.org, Srdan Milakovic Date: Mon, 04 Nov 2019 16:19:00 -0000 In-Reply-To: <1572063095.9092.1@rice.edu> References: <1566877968.10901.0@smtp.mail.rice.edu> <20190829131614.18190-1-mark@klomp.org> <20190829131614.18190-4-mark@klomp.org> <574ab190fb7be83abfaef0977f904a15de7a521a.camel@klomp.org> <1572063095.9092.1@rice.edu> Content-Type: multipart/mixed; boundary="=-d5BJT2asL8EV2Lv6ZLAu" X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00101.txt.bz2 --=-d5BJT2asL8EV2Lv6ZLAu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 632 Hi, On Fri, 2019-10-25 at 23:11 -0500, Jonathon Anderson wrote: > > I tried to simplify the code a little. You already observed that > > COMPARE can be zero. But it always is. We never try comparing values. > > So all the COMPARE and value passing to the find functions can simply > > be removed. So if you agree I would like to merge the attached > > simplification diff into this patch. >=20 > I'm fine with it, although at a glance it seems that this means=20 > insert_helper will never return -1. Which doesn't quite sound accurate,=20 > so I'll have to defer to Srdan on this one. Srdan, any feedback on this? Thanks, Mark --=-d5BJT2asL8EV2Lv6ZLAu Content-Disposition: attachment; filename="0001-no-compare-or-val-pass.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-no-compare-or-val-pass.patch"; charset="UTF-8" Content-length: 8301 RnJvbSBiNzBiMzUwMjQyZDk3NTJmNDE0MDdjMGVkN2ZlNDY4M2M4ZjMxY2U2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFdpZWxhYXJk IDxtYXJrQGtsb21wLm9yZz4KRGF0ZTogU2F0LCAyNiBPY3QgMjAxOSAwMTo1 NDo0MyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIG5vIGNvbXBhcmUgb3IgdmFs IHBhc3MKCi0tLQogbGliL2R5bmFtaWNzaXplaGFzaF9jb25jdXJyZW50LmMg fCA1MSArKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogbGliL2R5 bmFtaWNzaXplaGFzaF9jb25jdXJyZW50LmggfCAgMiArLQogbGliZHcvZHdh cmZfYWJicmV2X2hhc2guaCAgICAgICAgfCAgMSAtCiBsaWJkdy9kd2FyZl9n ZXRhYmJyZXYuYyAgICAgICAgICB8ICAyICstCiBsaWJkdy9kd2FyZl90YWcu YyAgICAgICAgICAgICAgICB8ICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDEw IGluc2VydGlvbnMoKyksIDQ4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpYi9keW5hbWljc2l6ZWhhc2hfY29uY3VycmVudC5jIGIvbGliL2R5bmFt aWNzaXplaGFzaF9jb25jdXJyZW50LmMKaW5kZXggZDY0NWIxNDMuLjVmYTM4 NzEzIDEwMDY0NAotLS0gYS9saWIvZHluYW1pY3NpemVoYXNoX2NvbmN1cnJl bnQuYworKysgYi9saWIvZHluYW1pY3NpemVoYXNoX2NvbmN1cnJlbnQuYwpA QCAtMzYsNDYgKzM2LDI0IEBACiAKICAgIE5BTUUgICAgICBuYW1lIG9mIHRo ZSBoYXNoIHRhYmxlIHN0cnVjdHVyZS4KICAgIFRZUEUgICAgICBkYXRhIHR5 cGUgb2YgdGhlIGhhc2ggdGFibGUgZW50cmllcwotICAgQ09NUEFSRSAgIGNv bXBhcmlzb24gZnVuY3Rpb24gdGFraW5nIHR3byBwb2ludGVycyB0byBUWVBF IG9iamVjdHMKLQotICAgVGhlIGZvbGxvd2luZyBtYWNyb3MgaWYgcHJlc2Vu dCBzZWxlY3QgZmVhdHVyZXM6Ci0KLSAgIElURVJBVEUgICBpdGVyYXRpbmcg b3ZlciB0aGUgdGFibGUgZW50cmllcyBpcyBwb3NzaWJsZQotICAgUkVWRVJT RSAgIGl0ZXJhdGUgaW4gcmV2ZXJzZSBvcmRlciBvZiBpbnNlcnQKICAqLwog CiAKIHN0YXRpYyBzaXplX3QKLWxvb2t1cCAoTkFNRSAqaHRhYiwgSEFTSFRZ UEUgaHZhbCwgVFlQRSB2YWwgX19hdHRyaWJ1dGVfXyAoKHVudXNlZCkpKQor bG9va3VwIChOQU1FICpodGFiLCBIQVNIVFlQRSBodmFsKQogewogICAvKiBG aXJzdCBoYXNoIGZ1bmN0aW9uOiBzaW1wbHkgdGFrZSB0aGUgbW9kdWwgYnV0 IHByZXZlbnQgemVyby4gIFNtYWxsIHZhbHVlcwogICAgICAgY2FuIHNraXAg dGhlIGRpdmlzaW9uLCB3aGljaCBoZWxwcyBwZXJmb3JtYW5jZSB3aGVuIHRo aXMgaXMgY29tbW9uLiAgKi8KICAgc2l6ZV90IGlkeCA9IDEgKyAoaHZhbCA8 IGh0YWItPnNpemUgPyBodmFsIDogaHZhbCAlIGh0YWItPnNpemUpOwogCi0j aWYgQ09NUEFSRSAhPSAwICAvKiBBIGhhbmRmdWwgb2YgdGFibGVzIGRvbid0 IGFjdHVhbGx5IGNvbXBhcmUgdGhlIGVudHJpZXMgaW4KLSAgICAgICAgICAg ICAgICAgICAgdGhlIHRhYmxlLCB0aGV5IGluc3RlYWQgcmVseSBvbiB0aGUg aGFzaC4gIEluIHRoYXQgY2FzZSwgd2UKLSAgICAgICAgICAgICAgICAgICAg Y2FuIHNraXAgcGFydHMgdGhhdCByZWxhdGUgdG8gdGhlIHZhbHVlLiAqLwot ICBUWVBFIHZhbF9wdHI7Ci0jZW5kaWYKICAgSEFTSFRZUEUgaGFzaDsKIAog ICBoYXNoID0gYXRvbWljX2xvYWRfZXhwbGljaXQoJmh0YWItPnRhYmxlW2lk eF0uaGFzaHZhbCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1l bW9yeV9vcmRlcl9hY3F1aXJlKTsKICAgaWYgKGhhc2ggPT0gaHZhbCkKLSAg ICB7Ci0jaWYgQ09NUEFSRSA9PSAwCi0gICAgICByZXR1cm4gaWR4OwotI2Vs c2UKLSAgICAgIHZhbF9wdHIgPSAoVFlQRSkgYXRvbWljX2xvYWRfZXhwbGlj aXQoJmh0YWItPnRhYmxlW2lkeF0udmFsX3B0ciwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVtb3J5X29yZGVyX2Fj cXVpcmUpOwotICAgICAgaWYgKENPTVBBUkUodmFsX3B0ciwgdmFsKSA9PSAw KQotICAgICAgICAgIHJldHVybiBpZHg7Ci0jZW5kaWYKLSAgICB9CisgICAg cmV0dXJuIGlkeDsKICAgZWxzZSBpZiAoaGFzaCA9PSAwKQotICAgIHsKLSAg ICAgIHJldHVybiAwOwotICAgIH0KKyAgICByZXR1cm4gMDsKIAogICAvKiBT ZWNvbmQgaGFzaCBmdW5jdGlvbiBhcyBzdWdnZXN0ZWQgaW4gW0tudXRoXS4g ICovCiAgIEhBU0hUWVBFIHNlY29uZF9oYXNoID0gMSArIGh2YWwgJSAoaHRh Yi0+c2l6ZSAtIDIpOwpAQCAtOTAsMjAgKzY4LDkgQEAgbG9va3VwIChOQU1F ICpodGFiLCBIQVNIVFlQRSBodmFsLCBUWVBFIHZhbCBfX2F0dHJpYnV0ZV9f ICgodW51c2VkKSkpCiAgICAgICBoYXNoID0gYXRvbWljX2xvYWRfZXhwbGlj aXQoJmh0YWItPnRhYmxlW2lkeF0uaGFzaHZhbCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBtZW1vcnlfb3JkZXJfYWNxdWlyZSk7CiAg ICAgICBpZiAoaGFzaCA9PSBodmFsKQotICAgICAgICB7Ci0jaWYgQ09NUEFS RSA9PSAwCi0gICAgICAgICAgcmV0dXJuIGlkeDsKLSNlbHNlCi0gICAgICAg ICAgdmFsX3B0ciA9IChUWVBFKSBhdG9taWNfbG9hZF9leHBsaWNpdCgmaHRh Yi0+dGFibGVbaWR4XS52YWxfcHRyLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVtb3J5X29yZGVyX2FjcXVp cmUpOwotICAgICAgICAgIGlmIChDT01QQVJFKHZhbF9wdHIsIHZhbCkgPT0g MCkKLSAgICAgICAgICAgICAgcmV0dXJuIGlkeDsKLSNlbmRpZgotICAgICAg ICB9CisJcmV0dXJuIGlkeDsKICAgICAgIGVsc2UgaWYgKGhhc2ggPT0gMCkK LSAgICAgICAgewotICAgICAgICAgIHJldHVybiAwOwotICAgICAgICB9CisJ cmV0dXJuIDA7CiAgICAgfQogfQogCkBAIC0xMjMsOCArOTAsNiBAQCBpbnNl cnRfaGVscGVyIChOQU1FICpodGFiLCBIQVNIVFlQRSBodmFsLCBUWVBFIHZh bCkKICAgICB7CiAgICAgICB2YWxfcHRyID0gKFRZUEUpIGF0b21pY19sb2Fk X2V4cGxpY2l0KCZodGFiLT50YWJsZVtpZHhdLnZhbF9wdHIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1lbW9yeV9v cmRlcl9hY3F1aXJlKTsKLSAgICAgIGlmIChDT01QQVJFKHZhbF9wdHIsIHZh bCkgIT0gMCkKLSAgICAgICAgICByZXR1cm4gLTE7CiAgICAgfQogICBlbHNl IGlmIChoYXNoID09IDApCiAgICAgewpAQCAtMTY4LDggKzEzMyw2IEBAIGlu c2VydF9oZWxwZXIgKE5BTUUgKmh0YWIsIEhBU0hUWVBFIGh2YWwsIFRZUEUg dmFsKQogICAgICAgICB7CiAgICAgICAgICAgdmFsX3B0ciA9IChUWVBFKSBh dG9taWNfbG9hZF9leHBsaWNpdCgmaHRhYi0+dGFibGVbaWR4XS52YWxfcHRy LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbWVtb3J5X29yZGVyX2FjcXVpcmUpOwotICAgICAgICAgIGlmIChD T01QQVJFKHZhbF9wdHIsIHZhbCkgIT0gMCkKLSAgICAgICAgICAgICAgcmV0 dXJuIC0xOwogICAgICAgICB9CiAgICAgICBlbHNlIGlmIChoYXNoID09IDAp CiAgICAgICAgIHsKQEAgLTQ5NSw3ICs0NTgsNyBAQCBUWVBFCiAjZGVmaW5l IEZJTkQobmFtZSkgX0ZJTkQgKG5hbWUpCiAjZGVmaW5lIF9GSU5EKG5hbWUp IFwKICAgbmFtZSMjX2ZpbmQKLUZJTkQoTkFNRSkgKE5BTUUgKmh0YWIsIEhB U0hUWVBFIGh2YWwsIFRZUEUgdmFsKQorRklORChOQU1FKSAoTkFNRSAqaHRh YiwgSEFTSFRZUEUgaHZhbCkKIHsKICAgd2hpbGUgKHB0aHJlYWRfcndsb2Nr X3RyeXJkbG9jaygmaHRhYi0+cmVzaXplX3J3bCkgIT0gMCkKICAgICAgIHJl c2l6ZV93b3JrZXIoaHRhYik7CkBAIC01MDQsNyArNDY3LDcgQEAgRklORChO QU1FKSAoTkFNRSAqaHRhYiwgSEFTSFRZUEUgaHZhbCwgVFlQRSB2YWwpCiAK ICAgLyogTWFrZSB0aGUgaGFzaCBkYXRhIG5vbnplcm8uICAqLwogICBodmFs ID0gaHZhbCA/OiAxOwotICBpZHggPSBsb29rdXAoaHRhYiwgaHZhbCwgdmFs KTsKKyAgaWR4ID0gbG9va3VwKGh0YWIsIGh2YWwpOwogCiAgIGlmIChpZHgg PT0gMCkKICAgICB7CmRpZmYgLS1naXQgYS9saWIvZHluYW1pY3NpemVoYXNo X2NvbmN1cnJlbnQuaCBiL2xpYi9keW5hbWljc2l6ZWhhc2hfY29uY3VycmVu dC5oCmluZGV4IGExMzdjYmQwLi43M2U2NmU5MSAxMDA2NDQKLS0tIGEvbGli L2R5bmFtaWNzaXplaGFzaF9jb25jdXJyZW50LmgKKysrIGIvbGliL2R5bmFt aWNzaXplaGFzaF9jb25jdXJyZW50LmgKQEAgLTk3LDcgKzk3LDcgQEAgZXh0 ZXJuIGludCBuYW1lIyNfZnJlZSAobmFtZSAqaHRhYik7ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcCiBleHRlcm4gaW50IG5hbWUjI19pbnNl cnQgKG5hbWUgKmh0YWIsIEhBU0hUWVBFIGh2YWwsIFRZUEUgZGF0YSk7ICAg IFwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogLyogRmluZCBlbnRyeSBp biBoYXNoIHRhYmxlLiAgKi8gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBcCi1leHRlcm4gVFlQRSBuYW1lIyNfZmluZCAobmFtZSAqaHRh YiwgSEFTSFRZUEUgaHZhbCwgVFlQRSB2YWwpOworZXh0ZXJuIFRZUEUgbmFt ZSMjX2ZpbmQgKG5hbWUgKmh0YWIsIEhBU0hUWVBFIGh2YWwpOwogI2RlZmlu ZSBGVU5DVElPTlMobmFtZSkgX0ZVTkNUSU9OUyAobmFtZSkKIEZVTkNUSU9O UyAoTkFNRSkKIApkaWZmIC0tZ2l0IGEvbGliZHcvZHdhcmZfYWJicmV2X2hh c2guaCBiL2xpYmR3L2R3YXJmX2FiYnJldl9oYXNoLmgKaW5kZXggYmMzZDYy YzcuLmEzNjhjNTk4IDEwMDY0NAotLS0gYS9saWJkdy9kd2FyZl9hYmJyZXZf aGFzaC5oCisrKyBiL2xpYmR3L2R3YXJmX2FiYnJldl9oYXNoLmgKQEAgLTMy LDcgKzMyLDYgQEAKIAogI2RlZmluZSBOQU1FIER3YXJmX0FiYnJldl9IYXNo CiAjZGVmaW5lIFRZUEUgRHdhcmZfQWJicmV2ICoKLSNkZWZpbmUgQ09NUEFS RShhLCBiKSAoMCkKIAogI2luY2x1ZGUgPGR5bmFtaWNzaXplaGFzaF9jb25j dXJyZW50Lmg+CiAKZGlmZiAtLWdpdCBhL2xpYmR3L2R3YXJmX2dldGFiYnJl di5jIGIvbGliZHcvZHdhcmZfZ2V0YWJicmV2LmMKaW5kZXggNmE3ZTk4MWIu LjdlNzY3ZmMxIDEwMDY0NAotLS0gYS9saWJkdy9kd2FyZl9nZXRhYmJyZXYu YworKysgYi9saWJkdy9kd2FyZl9nZXRhYmJyZXYuYwpAQCAtODMsNyArODMs NyBAQCBfX2xpYmR3X2dldGFiYnJldiAoRHdhcmYgKmRiZywgc3RydWN0IER3 YXJmX0NVICpjdSwgRHdhcmZfT2ZmIG9mZnNldCwKICAgYm9vbCBmb3VuZGl0 ID0gZmFsc2U7CiAgIER3YXJmX0FiYnJldiAqYWJiID0gTlVMTDsKICAgaWYg KGN1ID09IE5VTEwKLSAgICAgIHx8IChhYmIgPSBEd2FyZl9BYmJyZXZfSGFz aF9maW5kICgmY3UtPmFiYnJldl9oYXNoLCBjb2RlLCBOVUxMKSkgPT0gTlVM TCkKKyAgICAgIHx8IChhYmIgPSBEd2FyZl9BYmJyZXZfSGFzaF9maW5kICgm Y3UtPmFiYnJldl9oYXNoLCBjb2RlKSkgPT0gTlVMTCkKICAgICB7CiAgICAg ICBpZiAocmVzdWx0ID09IE5VTEwpCiAJYWJiID0gbGliZHdfdHlwZWRfYWxs b2MgKGRiZywgRHdhcmZfQWJicmV2KTsKZGlmZiAtLWdpdCBhL2xpYmR3L2R3 YXJmX3RhZy5jIGIvbGliZHcvZHdhcmZfdGFnLmMKaW5kZXggMzMxZWFhMGQu LmQ3ODQ5NzBjIDEwMDY0NAotLS0gYS9saWJkdy9kd2FyZl90YWcuYworKysg Yi9saWJkdy9kd2FyZl90YWcuYwpAQCAtNDUsNyArNDUsNyBAQCBfX2xpYmR3 X2ZpbmRhYmJyZXYgKHN0cnVjdCBEd2FyZl9DVSAqY3UsIHVuc2lnbmVkIGlu dCBjb2RlKQogICAgIHJldHVybiBEV0FSRl9FTkRfQUJCUkVWOwogCiAgIC8q IFNlZSB3aGV0aGVyIHRoZSBlbnRyeSBpcyBhbHJlYWR5IGluIHRoZSBoYXNo IHRhYmxlLiAgKi8KLSAgYWJiID0gRHdhcmZfQWJicmV2X0hhc2hfZmluZCAo JmN1LT5hYmJyZXZfaGFzaCwgY29kZSwgTlVMTCk7CisgIGFiYiA9IER3YXJm X0FiYnJldl9IYXNoX2ZpbmQgKCZjdS0+YWJicmV2X2hhc2gsIGNvZGUpOwog ICBpZiAoYWJiID09IE5VTEwpCiAgICAgd2hpbGUgKGN1LT5sYXN0X2FiYnJl dl9vZmZzZXQgIT0gKHNpemVfdCkgLTFsKQogICAgICAgewotLSAKMi4xOC4x Cgo= --=-d5BJT2asL8EV2Lv6ZLAu--