From: Ulf Hermann <ulf.hermann@qt.io>
To: elfutils-devel@sourceware.org
Subject: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv
Date: Mon, 16 Jul 2018 10:02:00 -0000 [thread overview]
Message-ID: <e6b56d2b-4506-ffbf-565b-44e49c679b99@qt.io> (raw)
strip does not produce debug files for riscv binaries. If this is a bug
it needs to be fixed in strip, but for now, we disable the tests.
Change-Id: I1bf3deaf1ec0883f345b232bc4ceb56601f5bf79
Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
tests/ChangeLog | 4 ++++
tests/run-strip-reloc.sh | 7 ++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 4e293d4b..d510c35f 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,5 +1,9 @@
2018-07-16 Ulf Hermann <ulf.hermann@qt.io>
+ * run-strip-reloc.sh: Skip checking debug files on riscv.
+
+2018-07-16 Ulf Hermann <ulf.hermann@qt.io>
+
* run-strip-reloc.sh: Remove previous testfiles before running the
next test.
diff --git a/tests/run-strip-reloc.sh b/tests/run-strip-reloc.sh
index 41afeeb8..31671c64 100755
--- a/tests/run-strip-reloc.sh
+++ b/tests/run-strip-reloc.sh
@@ -27,6 +27,7 @@ status=0
runtest() {
infile=$1
is_ET_REL=$2
+ skip_debugfiles=$3
outfile1=out.stripped1
debugfile1=out.debug1
outfile2=out.stripped2
@@ -48,6 +49,10 @@ runtest() {
testrun_compare ${abs_top_builddir}/src/readelf -a $outfile2 < readelf.out ||
{ echo "*** failure compare stripped files $infile"; status=1; }
+ if [ $skip_debugfiles ]; then
+ return
+ fi
+
# debug files however should be smaller, when ET_REL.
SIZE1=$(stat -c%s $debugfile1)
SIZE2=$(stat -c%s $debugfile2)
@@ -105,7 +110,7 @@ runtest hello_ppc64.ko 1
runtest hello_s390.ko 1
runtest hello_aarch64.ko 1
runtest hello_m68k.ko 1
-runtest hello_riscv64.ko 1
+runtest hello_riscv64.ko 1 1
# self test, shouldn't impact non-ET_REL files at all.
runtest ${abs_top_builddir}/src/strip 0
--
2.11.0
next reply other threads:[~2018-07-16 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:02 Ulf Hermann [this message]
2018-07-16 22:01 ` Mark Wielaard
2018-07-17 9:29 ` Andreas Schwab
2018-07-17 9:49 ` Ulf Hermann
2018-07-17 10:06 ` Andreas Schwab
2018-07-17 10:05 ` Mark Wielaard
2018-07-17 10:09 ` Andreas Schwab
2018-07-17 10:33 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b56d2b-4506-ffbf-565b-44e49c679b99@qt.io \
--to=ulf.hermann@qt.io \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).