From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89504 invoked by alias); 27 Apr 2017 14:35:28 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 89476 invoked by uid 89); 27 Apr 2017 14:35:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=51gX304fxM9nhxGagD7P3PU+Q6vVMTNQBh7wrxqUpIo=; b=XQCMlGj4iqBq/3dTjVWJQ7QBWKkuy8RJKS+OEvQU3CMElezckypP9UzOWfnv2Ik+8TSUbn+bxUrClzKWYIXDwwKolrJMzatVSyKhccr1y/2U65rBQnOlHftCUItS4n5m+vzd1Kzm2xpf8jbc6cLPK4vSmP7cFLXvbvc+58iqh7I= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; From: Ulf Hermann Subject: [PATCH] Fix nesting of braces To: Message-ID: Date: Thu, 27 Apr 2017 16:02:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: VI1PR0802CA0007.eurprd08.prod.outlook.com (2603:10a6:800:aa::17) To AMSPR02MB229.eurprd02.prod.outlook.com (2a01:111:e400:8022::15) X-MS-Office365-Filtering-Correlation-Id: b45721e3-2947-4a57-9aad-08d48d7aa3fa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:AMSPR02MB229; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB229;3:Av3Abor59XD6P63eIXrG1ruSDvL5mRModMYgxdPBx6AvBkKzFzeWHgsJnculeloIQB2nYxJJyts3BFy16NqmL+GpZb9Dlli0n6BZLPj7YeFmf/XWlF0Prafy5uAPY/+5A6dEDAah8hcrPriDrJ/jWdfrtfj4v4V/ydyPTERlwq/RJuk/uBnyVl4/SKiJHKXYXVcm49KTW7nDZ3fYNaxcB2T3+JzACPFoA6fyztDWJWWKSPcbi19kYk3JS7Xkq69WLzU8YcvcVYbZC2YyHTKzr5uf2rUW3B+ZV4nE68V6LvozfAe77Z0GSKFpJL2GAD4mnwd99hBP1qdbInHBP9LuQg==;25:/96HBpGwr5uOudPCPXSB3pxrT8mMJiXWb78Ti+SxMOO3sU9Ovx3hGesYdYLBVISLEor9Sh+uoPqNj8tm98MNR9NX37J3T9U538xpdGZJDVxzb+UPlweaOLxyqCC+XcS20YKbnf1qRX1J9Ej9OX7QPhADQu7GSLecRkSKPE5UlreGEKVMXVTZDKYpCp1yQacBWCeHM5uHZyjz4WaI3xbzW2W8rrW2tSRarlV69wVtYohbotPhAFAiXSRd3yL+xk78YGoTLPKq904KOiAj9kjJz8IGBXuPyK9ZV3aPZJiq40mROme7FEe+8FV4E+sdIirON4umJs/7TO33FOqHNiej48Luc/JlEvPy1ETaSgokYgmgUCK0N7KToCBKQ/Da8p0d47tL0iBR43Yvkie78e2luDODSS9TgBUweXP0bNv/S5ZqBNGuVC9vkO1DJASzAMsQIqY1xaoINhISKxeL+YPxQg== X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB229;31:V70fGmNp1NAjKW3kqoUJMxWfySLJW1GMMLjpLBaBuWAGSqj36vHZIhG/1TPCsIQohuN8uh3Bxg3uHc04BVBgFiFIDacQ6xV2NrBaLkEhAmskltEd6525nr0kLjJb2hFXBdNwIDSRXCQ6vSRnlorLdb6uGsOCFQ/wX26UznkOYHB6ZuP8xAVOVEqSy+64nho2EwG76lQfF0EeI1Wv1Dz8Mdjx2FMhleaMpnjZfBNMN4IdtNiFxEUkSPoMlovCmRx2uwNJOqoxU/FFJ1SeevzVO2yFeMZ+O2SO5ZDUcaAXDGk=;20:Mj/zTJdcuk5hXJh1oUVxi2lmpK/DAO1s996Cf5Ocvqm3EWRHt1izdOuh2RMZy+7K3w7ZL0PfawE51FVO/c/tC9Yhf/3FXP5xgD4X7u7T2xLMtADpKdlcO3XLe2hdPCqcKPaaozQMtq1eRRwBI4kk8WnoSJq5hi/wzNijOIlPwVeAoeiAHB1zb+NoWBMQuCVSnk4V4uKIoESzYLhLrIn9x2AinSl2RmD0xPIvCpwu62Vb9B/j8OJqmnU9bgMjNrRb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(6072148);SRVR:AMSPR02MB229;BCL:0;PCL:0;RULEID:;SRVR:AMSPR02MB229; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB229;4:ikQQ8mMBAvSFkrc3D7s8hAlLIyohZyTKwjTj77YbnseSs+dk2Q0a0Epk0WZjkPZsryFJB6PyjJ8PjjNPx78SIfFSAaMAZVtm+wjMGqzxQssbPaY+YtRnpmLvVz+DrLYfWK1dWDUNEnecnLBo+AKxGiZCLGX+I4cQmHa9u4LSFemSabaIdCfRd+sw90YObECMFWXu8lmssU8MswlqXhpB20sSKEF4AqBtqHfvqWXOp3DArvQ4ukGYATpCfAduHiO6cNNw46xebZmF6kq/QAWXdkdfQQeHLORwkTdzk9y261elRxtmd8Tx3w99hB1ZqE6RqO+eDS9XtqLgijK4CYqSL0Z4sQ9wq2h86Yvbj16t3sUu/xvJ9jVOVLFEyGAl2F/McP0GifRVIhbRw24atF4ZHXeP8aC1wFxkWtNlfR71S44XdB3ttZrswzPq0bqUMxsPcWwSOVlzJIEFOzQHm9iH822KjYzgGLSSFQblOr8Nz5H1a32z89wia07Dxzyqc1sKxk2CydnbA4enVBBjZwz79gG2fYQx+aosVovFHZs09a/PyUdhW7tbxleDiF9epuZXHupXSUlaI2vAicm3HiAG4M1SDEQt9adYs+aqAwDBhy3z3PHC1ccD0DVrzZ/NSWvD6Tj0VLod6d5M/M6rEUR6AvIryUVDdyHnSgTdJF1i1GvJKiDpHzawlp3blFhq+S4fjqjK5/Z8KW1HzUIrLC7g8J9Sxo7lykY8r23nKQI3ZPj1xLnfnXApoQRxOZTLNPG9GW0NRrw7mlyYP2BZWNtvnLoQeEequadebV6+nN+9zhM= X-Forefront-PRVS: 029097202E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39400400002)(39410400002)(39830400002)(377424004)(6916009)(86362001)(2351001)(31696002)(33646002)(42186005)(189998001)(64126003)(31686004)(74482002)(50466002)(23676002)(2906002)(8676002)(53936002)(81166006)(110136004)(6116002)(3846002)(38730400002)(25786009)(305945005)(65826007)(47776003)(230700001)(65956001)(6486002)(5660300001)(54356999)(77096006)(65806001)(66066001)(36756003)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR02MB229;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjAyTUIyMjk7MjM6cmR6WEhQYmJsUFpBNmVLcTdLOVRqZ255OXRl?= =?utf-8?B?OWJzSEJZYlhEbU5DOFN4QlBTSnNlWHpXQTRRVnF5SkxkYVhlWUpYRE1NdHhr?= =?utf-8?B?TFZnUEJ4b21PQkpLa212TXFoTWJpcWk5YVJaRVU4ejMrbnd0Uk85Q3ZOdE9u?= =?utf-8?B?eCtOM0NQMWRISGpLMitEd0h0ZlB4QlA2TzJVVUR1eWdycUtiUVF3WGIxV28w?= =?utf-8?B?RVpmYjdEbjl0aU4wKzJncGIwVDl1YnZ2bTlIZWRUQUptRjE4emlDU014dnNL?= =?utf-8?B?S2dET2w1Q21pb25EWUg0N25BZmFrL0FhdnBzNHdsYUtZVHdpUWdqbjlKbHJo?= =?utf-8?B?ajBLTUFpM1JLSTFKY3BtSllkRFptMjZEdVpEbHd1aEx1dkt5YjduV1U3SzdV?= =?utf-8?B?K3loc3lHZFNaMWtQclcxWEdhS3hkbDc1Y3B2cHBWdi9BcU0vTEdkVnFVVzlS?= =?utf-8?B?SjZ4TlRjZUQrOXF3dEpHeFFZcW5uRFZtZlpRNldsb0E5czJMMW5UKzNrc3F2?= =?utf-8?B?UjVTMmhHM1JUU3ptTkQzQTFnQTdWQ0djSCtTNWFGL3VrRHZ1TG1INWp6Q3lu?= =?utf-8?B?dmJLY3Y0Rk4xV3pnaUQ0VWE1dWtvQ0FYM09uMVI2R3MxbmdUcXl1TkFpc0ZN?= =?utf-8?B?Z3hsYkNwYnl2dGhtcFNlNzlDd0ZRcUtCWkMraVUrc3ljRGtKYTZMS2RTbS9N?= =?utf-8?B?NlJ6UUQrOUJzVHZMZEZaUTAxRklCZi9kcHM2Nmk2cUtlUGNjU3VkUU5wWGUy?= =?utf-8?B?RzhMb3lRRjlBdyt3M1J3aGJKZERTL3UxZ2F1cmFoTHVlRk1qdXhxTTR0VGxs?= =?utf-8?B?Y01RYUZYbmlPNDlhUXZGZWtGblIzMGpOQTJMeWpwVHk4ZXhRUlh3RTcxb2pV?= =?utf-8?B?cHIvYWdjOTlPU1ZJL3orRStteGJzZDM0UExQOVI2MVg5SmxoYVhPdGZUVTM1?= =?utf-8?B?NE9uc1JTVUt5UkpwbDk2VWk3QktabncwdGUyaTdpTDVSeCs3WWg4TWM0TVB2?= =?utf-8?B?WG5LcEVGd25HMk5wQ1A2VjVKeGtheTFXVWpCOGV3K0JKUk01bFdCbml0VjI3?= =?utf-8?B?bzA1OEJ6MGlaZjIyRkEzeWlOYUJSS1dNcW14by9zak9MK0dGL2c1eFExcERV?= =?utf-8?B?ckkvT2ZBeEoyakxvV2ExVmNVdjZIY1hNS1l4djJMSmQ4YlVoTHZEd0lNSm9L?= =?utf-8?B?SU8rL3M1WklxczdxSkpqUThPVnlSbE1VQWR0c2RuWGVQa1ZlR1U2YUV3WGg5?= =?utf-8?B?VUFUbGE5Nm0yNEJERXNwdTlabVQxRnpvRXpYcWh6YUpoYWd3YlR4d2p4ckNq?= =?utf-8?B?NlQ4WXFaQUYxSStRTzVaSi9TblBJTm12QTltalU5M3VZOVdtK29XU2pIb0xW?= =?utf-8?B?T2dBaElZZUwwMVFFZkRUaGliRzFCZ1g1VGJoVCs3QlNudGZHeVNRM0hwMU9U?= =?utf-8?Q?yizow=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB229;6:H34RXi1zBNwTMZwlFlczupxOqpQiDFu/6L8fLVVbkd2M9myCdsjjQwD2WOQXsBR7gvW6PUQvvOsVkLNCXjIwoUx1swDU9KkL+TTvVItBoMD2m5k/AOM4bnwfggKfo7C17LZJQaWq+CaMwtsNC9m+xV6I788TfyawF/29yub3xni2iP/X/93JDfcevLi1GzN5g4+GlMw0RnljeE9zvTSCtnCQEeYC5M6nvXRtd6T2sFWmjuKfesPnfJZDAAYas3E7/A0c6CTMSNkbWgdMEzb/BK8dc+cDtkECEz+Ehp6Tcr5X1WQHwRaBMwXwIxB4YV3ccSddj3L+zrTGyuhuhjoZ0r02yDBsn4rd2aLnIvrgrYb/QxoFaQqWKm8CVWcOe3SD/iz8PUck2l8XO/z/CUbdN7GjqOxqo7wucDCbUVoeUrQ3xR2E7IY+CJtV94O4IoIRNTxTJ5c2SAstprXqq/r9e4MFVOGzO+4HJaBbH+1/AO6Ea9p3dKTE9fUbZAm+G2i6183ihfDWwPpiN1UmZhicVA==;5:Hcq8g21cQxcaPvl63RkxdSRIyPhEw/k8BeKUGKjMdpctjOZk2xDCWJvAT43qz5Xr8Sj3EoLE90t27TlNUgcX+vg1IPRlGAV6Jv1G4eF6gNGWw2r5eiN5PxeV5g6qwYdbF31SaQQuQxrSZIZgCML7QQ==;24:0A5CD7bngpFI6wTrUYJnaWz9d2zc3BXFU8bqKpoZq1XEotFYFsYSZAGgttC0MXQwf6d1ZHBan5YtWvPXBB/aEXHqv4tYt8gW98dwSrW5WEU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB229;7:+/T2hBczOqYZBdDz6UXP/0cK3HS7wThxgn8RkL4q5lndoA781YCLFphpviznp2Bc/bJMMy0R6gEWfrpFCCzgOjgbkOHeEaHGfHv9KF6F3D5oJpjhbKqe/jCajMenyaPcJ4vxgfhxrTqcT6o0PIDHaQzhNuHw4I72B4nzHhNpa1b27FVxORKVeHR95YoOiDd64pc03aBvJBSPQJc+vkg6a5l5ocAoSWN1JWKu93bIDcdhz8+V7Lz+YzhOQAlZteMYiASGJx4lgV2qEB/rfkXr2/v2k/Wt8hPDQwCpHs7vzKS+SWN/Osz9AoUHMyILhUP1qigrO/T4jX4VhQ/1wIpILw== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2017 14:35:24.1312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR02MB229 X-SW-Source: 2017-q2/txt/msg00107.txt.bz2 The way it was before it didn't actually test if elf_update failed, but rather did something random. !!() is a boolean and boolean true can be represented as anything non-0, including negative numbers. Signed-off-by: Ulf Hermann --- libasm/ChangeLog | 4 ++++ libasm/asm_end.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libasm/ChangeLog b/libasm/ChangeLog index 1656842..d2bc408 100644 --- a/libasm/ChangeLog +++ b/libasm/ChangeLog @@ -1,3 +1,7 @@ +2017-04-27 Ulf Hermann + + * asm_end.c (binary_end): Fix nesting of braces. + 2017-02-12 Mark Wielaard * asm_newsym.c (asm_newsym): Increase TEMPSYMLEN to 13. diff --git a/libasm/asm_end.c b/libasm/asm_end.c index 191a535..ced24f5 100644 --- a/libasm/asm_end.c +++ b/libasm/asm_end.c @@ -464,7 +464,7 @@ binary_end (AsmCtx_t *ctx) gelf_update_ehdr (ctx->out.elf, ehdr); /* Write out the ELF file. */ - if (unlikely (elf_update (ctx->out.elf, ELF_C_WRITE_MMAP)) < 0) + if (unlikely (elf_update (ctx->out.elf, ELF_C_WRITE_MMAP) < 0)) { __libasm_seterrno (ASM_E_LIBELF); result = -1; -- 2.8.1.windows.1