From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id ACCCD3857C55 for ; Thu, 23 Feb 2023 16:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACCCD3857C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id ABCC830067D6; Thu, 23 Feb 2023 17:22:53 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 8F6EA34025A; Thu, 23 Feb 2023 17:22:52 +0100 (CET) Message-ID: Subject: Re: [PATCH 1/4] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register From: Mark Wielaard To: German Gomez , elfutils-devel@sourceware.org Date: Thu, 23 Feb 2023 17:22:52 +0100 In-Reply-To: <20220425140311.95231-2-german.gomez@arm.com> References: <20220425140311.95231-1-german.gomez@arm.com> <20220425140311.95231-2-german.gomez@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3035.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi German, On Mon, 2022-04-25 at 14:03 +0000, German Gomez via Elfutils-devel wrote: > This register will be used to indicate whether a return address is > mangled with a PAC or not, in accordance with the DWARF AARCH64 ABI [1]. >=20 > [1] https://github.com/ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.= rst#41dwarf-register-names This looks good. With one nit: > diff --git a/libdw/dwarf.h b/libdw/dwarf.h > index 3ce7f236..f234c411 100644 > --- a/libdw/dwarf.h > +++ b/libdw/dwarf.h > @@ -1011,6 +1011,11 @@ enum > DW_EH_PE_indirect =3D 0x80 > }; > =20 > +/* AARCH64 DWARF registers. */ > +enum > + { > + DW_AARCH64_RA_SIGN_STATE =3D 34 > + }; > =20 > /* DWARF XXX. */ > #define DW_ADDR_none 0 dwarf.h is a public header. I rather not define this DW constant here. Especially since it doesn't seem to have common name (binutils-gdb calls this AARCH64_DWARF_RA_SIGN_STATE, but only defines it in a private header). Lets move this into cfi.c as private implementation detail in the next patch. Thanks, Mark