From: Mark Wielaard <mark@klomp.org>
To: tbaeder@redhat.com, elfutils-devel@sourceware.org
Subject: Re: link_map: Remove nested functions
Date: Sun, 06 Dec 2020 14:41:54 +0100 [thread overview]
Message-ID: <e89aa1062c8875c8cefd4360af22a220a7cc4cb1.camel@klomp.org> (raw)
In-Reply-To: <20201201083854.1870943-1-tbaeder@redhat.com>
Hi Timm,
On Tue, 2020-12-01 at 09:38 +0100, Timm Bäder via Elfutils-devel wrote:
> the attached patches get rid of nested functions in
> libdwfl/link_map.c.
>
> I wrote these a while back and just looked at them again and we could
> use the same read_state struct here as well. I just quickly checked,
> but it seems a bit more involved due to the
> integrated_memory_callback
> handling. I can look into that anyway if required.
I had some comments on the first patch, the third patch seems fine and
has been committed. If you have adjust for the changes in the first
patch it would be nice if you could look at making the second patch
read_addrs function take a bit less than 11 arguments,
Note that all patches were missing ChangeLog entries and Signed-off-by
lines.
Cheers,
Mark
prev parent reply other threads:[~2020-12-06 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 8:38 tbaeder
2020-12-01 8:38 ` [PATCH 1/3] link_map: Pull release_buffer() into file scope tbaeder
2020-12-06 13:20 ` Mark Wielaard
2020-12-01 8:38 ` [PATCH 2/3] link_map: Pull read_addrs() in " tbaeder
2020-12-01 8:38 ` [PATCH 3/3] link_map: Inline consider_phdr() into only caller tbaeder
2020-12-06 13:39 ` Mark Wielaard
2020-12-06 13:41 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e89aa1062c8875c8cefd4360af22a220a7cc4cb1.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).