From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id CB31D3857831 for ; Mon, 26 Oct 2020 18:46:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CB31D3857831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DDAD230278CD; Mon, 26 Oct 2020 19:46:08 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id BC06241E79D3; Mon, 26 Oct 2020 19:46:08 +0100 (CET) Message-ID: Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included. From: Mark Wielaard To: =?ISO-8859-1?Q?=C9rico?= Nogueira , elfutils-devel@sourceware.org Date: Mon, 26 Oct 2020 19:46:08 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 18:46:11 -0000 Hi =C3=89rico, On Mon, 2020-10-26 at 01:11 -0300, =C3=89rico Nogueira via Elfutils-devel w= rote: > debuginfod.cxx used the bindtextdomain() and textdomain() functions > despite not including any translated output. These functions were also > used without including the libintl.h header. debuginfod doesn't directly use any translated output, but it links against libeu.a which provides the print_version function, which does use translated output. So maybe the correct fix is to #include instead? Cheers, Mark