From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 923533847813 for ; Fri, 9 Jul 2021 14:24:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 923533847813 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 6084C30016BF; Fri, 9 Jul 2021 16:24:45 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 131D0401656F; Fri, 9 Jul 2021 16:24:40 +0200 (CEST) Message-ID: Subject: Re: [debuginfod/25978] From: Mark Wielaard To: Noah Sanci , elfutils-devel@sourceware.org Date: Fri, 09 Jul 2021 16:24:39 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2021 14:24:49 -0000 Hi Noah, On Thu, 2021-07-08 at 15:22 -0400, Noah Sanci via Elfutils-devel wrote: > Please find the patch information for pr25978 attached. Thanks for allowing zero as fd and mb size, updating the documentation and adding comments for where I misunderstood what the code was doing in the previous review. I like the trick using grep of the vlog to make sure the reported metrics are correct (although that is slightly cheating, the metrics report what the log logs). Just one question about the last test: > +######################################################################## > +## PR25978 > +# Ensure that the fdcache options are working. > +grep "prefetch fds" vlog$PORT1 > +grep "prefetch mbs" vlog$PORT1 > +grep "fdcache fds" vlog$PORT1 > +grep "fdcache mbs" vlog$PORT1 > +# search the vlog to find what metric counts should be and check the cor= rect metrics > +# were incrimented > +wait_ready $PORT1 'fdcache_op_count{op=3D"enqueue"}' $( grep -c 'interne= d.*front=3D1' vlog$PORT1 ) > +wait_ready $PORT1 'fdcache_op_count{op=3D"evict"}' $( grep -c 'evicted a= =3D.*' vlog$PORT1 ) > +wait_ready $PORT1 'fdcache_op_count{op=3D"prefetch_enqueue"}' $( grep -c= 'interned.*front=3D0' vlog$PORT1 ) > +wait_ready $PORT1 'fdcache_op_count{op=3D"prefetch_evict"}' $( grep -c '= evicted from prefetch a=3D.*front=3D0' vlog$PORT1 || true ) > +# if all enqueued items are also evicted then we should expect prefetch = to be empty > +if [ $PF_ENQUEUED -eq $PF_EVICTED ]; then > + wait_ready $PORT1 'fdcache_prefetch_bytes' 0 > + wait_ready $PORT1 'fdcache_prefetch_count' 0 > +fi PF_ENQUEUED and PF_EVICTED are not used or set anywhere, so the if is always true, so we always check that the prefetch bytes and counts are zero. Is this intended? Thanks, Mark