From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 382603858438 for ; Tue, 14 Feb 2023 14:16:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 382603858438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 3DAA330067DA; Tue, 14 Feb 2023 15:16:35 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id C140F34033B; Tue, 14 Feb 2023 15:16:34 +0100 (CET) Message-ID: Subject: Re: [PATCH v3 3/4] backends: Support returning lvalue and rvalue references From: Mark Wielaard To: Ilya Leoshkevich , "Frank Ch . Eigler" Cc: elfutils-devel@sourceware.org Date: Tue, 14 Feb 2023 15:16:34 +0100 In-Reply-To: <20230213164551.550400-4-iii@linux.ibm.com> References: <20230213164551.550400-1-iii@linux.ibm.com> <20230213164551.550400-4-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3036.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ilya, On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote: > On the low level, they are the same as pointers. The change needs to be > done for all backends, so define a function and a macro to avoid > repetition. Also add a native test, which has to be implemented in C++. > Add the configure check for it. I love everything about this patch (except for missing a ChangeLog entry, but lets ignore that). The way you abstracted the pointer type for the backends, the new test and the configure addition are all very nice. There is one small issue with the test. In case there is a C++11 compiler available run-funcretval++11.sh is added to TESTS twice, and it is never added to EXTRA_DIST. So I pushed it with this small change: diff --git a/tests/Makefile.am b/tests/Makefile.am index bfc03061..efbb4e63 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -203,7 +203,7 @@ TESTS =3D run-arextract.sh run-arsymtest.sh run-ar.sh n= ewfile test-nlist \ $(asm_TESTS) run-disasm-bpf.sh run-low_high_pc-dw-form-indirect.sh = \ run-nvidia-extended-linemap-libdw.sh run-nvidia-extended-linemap-re= adelf.sh \ run-readelf-dw-form-indirect.sh run-strip-largealign.sh \ - run-readelf-Dd.sh run-funcretval++11.sh + run-readelf-Dd.sh =20 if !BIARCH export ELFUTILS_DISABLE_BIARCH =3D 1 @@ -610,7 +610,8 @@ EXTRA_DIST =3D run-arextract.sh run-arsymtest.sh run-ar= .sh \ run-readelf-dw-form-indirect.sh testfile-dw-form-indirect.bz2 = \ run-nvidia-extended-linemap-libdw.sh run-nvidia-extended-linem= ap-readelf.sh \ testfile_nvidia_linemap.bz2 \ - testfile-largealign.o.bz2 run-strip-largealign.sh + testfile-largealign.o.bz2 run-strip-largealign.sh \ + run-funcretval++11.sh =20 =20 if USE_VALGRIND Thanks, Mark