From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31972 invoked by alias); 26 Nov 2018 10:36:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 31954 invoked by uid 89); 26 Nov 2018 10:36:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 10:36:48 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 74115302BB40 for ; Mon, 26 Nov 2018 11:36:46 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 24D9E400E83B; Mon, 26 Nov 2018 11:36:46 +0100 (CET) Message-ID: Subject: Re: [PATCH] libdw: Enable building with -Og. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Mon, 26 Nov 2018 10:36:00 -0000 In-Reply-To: <1543003691-6344-1-git-send-email-mark@klomp.org> References: <1543003691-6344-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00189.txt.bz2 On Fri, 2018-11-23 at 21:08 +0100, Mark Wielaard wrote: > When building with -Og gcc is unable to see that __libdw_dieabbrev () > will initialize what the second argument points to when no error > occurs > as called by dwarf_child and dwarf_getattrs. Causing an possibly > uninitialized error. Just initialize readp/die_addr to NULL, which is > the value we would return if an error occurs anyway. >=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D23914 Pushed to master.