From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117328 invoked by alias); 17 Jul 2019 10:00:28 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 117199 invoked by uid 89); 17 Jul 2019 10:00:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jul 2019 10:00:18 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 3BB4B305088D; Wed, 17 Jul 2019 12:00:15 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id E67DC401CCAA; Wed, 17 Jul 2019 12:00:14 +0200 (CEST) Message-ID: Subject: Re: [PATCH V4 0/1] Add C-SKY support From: Mark Wielaard To: Mao Han Cc: elfutils-devel@sourceware.org Date: Wed, 17 Jul 2019 10:00:00 -0000 In-Reply-To: <20190717011951.GA3584@vmh-VirtualBox> References: <28258bf60492011cde0aaaded27ca6f4b6914de1.camel@klomp.org> <20190717011951.GA3584@vmh-VirtualBox> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00061.txt.bz2 Hi Mao Han, On Wed, 2019-07-17 at 09:19 +0800, Mao Han wrote: > > The new patch looks really good. Thanks. The addition of the testcases > > really helps showing things look good. I can make that one small fix > > s/gnu/csky/ in csky_attrs.c if you agree that is what was intended. > > Then I'll push it to master. >=20 > Yes, please. Thanks for your review and help improveing the patch. Pushed (with one small tweak, added the new test bz2 files to EXTRA_DIST so they will also be in any release tar balls). Thanks, Mark