From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id CB0513858D39 for ; Wed, 8 Feb 2023 18:15:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0513858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1C04830067CA; Wed, 8 Feb 2023 19:15:40 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id D3F0F3402CC; Wed, 8 Feb 2023 19:15:39 +0100 (CET) Message-ID: Subject: Re: [PATCH RFC 07/11] addr2line: Do not test demangling in run-addr2line-i-test.sh From: Mark Wielaard To: Ilya Leoshkevich , elfutils-devel@sourceware.org Date: Wed, 08 Feb 2023 19:15:39 +0100 In-Reply-To: <20230206222513.1773039-8-iii@linux.ibm.com> References: <20230206222513.1773039-1-iii@linux.ibm.com> <20230206222513.1773039-8-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ilya, On Mon, 2023-02-06 at 23:25 +0100, Ilya Leoshkevich via Elfutils-devel wrote: > There is run-addr2line-i-demangle-test.sh for that. Well spotted. Pushed as is. Thanks, Mark > Signed-off-by: Ilya Leoshkevich > --- > tests/run-addr2line-i-test.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/tests/run-addr2line-i-test.sh b/tests/run-addr2line-i-test.s= h > index 4f63e487..e7b89083 100755 > --- a/tests/run-addr2line-i-test.sh > +++ b/tests/run-addr2line-i-test.sh > @@ -254,13 +254,13 @@ EOF > =20 > testfiles testfile-inlines-lto > =20 > -testrun_compare ${abs_top_builddir}/src/addr2line --pretty -fiC -e testf= ile-inlines-lto 0x1118 0x1137 <<\EOF > -foobar(int) at /tmp/x.cpp:4:14 > - (inlined by) foo(int) at /tmp/x.cpp:22:16 > - (inlined by) fu(int) at /tmp/x.cpp:27:13 > -fubar(int) at /tmp/x.cpp:10:14 > - (inlined by) bar(int) at /tmp/x.cpp:16:15 > - (inlined by) fu(int) at /tmp/x.cpp:27:24 > +testrun_compare ${abs_top_builddir}/src/addr2line --pretty -fi -e testfi= le-inlines-lto 0x1118 0x1137 <<\EOF > +_Z6foobari at /tmp/x.cpp:4:14 > + (inlined by) _Z3fooi at /tmp/x.cpp:22:16 > + (inlined by) _Z2fui at /tmp/x.cpp:27:13 > +_Z5fubari at /tmp/x.cpp:10:14 > + (inlined by) _Z3bari at /tmp/x.cpp:16:15 > + (inlined by) _Z2fui at /tmp/x.cpp:27:24 > EOF > =20 > exit 0