From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@elastic.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: PATCH PR30962, debuginfod
Date: Wed, 11 Oct 2023 16:50:51 +0200 [thread overview]
Message-ID: <fb83dcee9b6110c92ac5086ff07f6f9360c03da9.camel@klomp.org> (raw)
In-Reply-To: <ZSavrbim6VSd3tLL@elastic.org>
Hi Frank,
On Wed, 2023-10-11 at 10:22 -0400, Frank Ch. Eigler wrote:
> > I think this makes sense, but it would be good to see an example of the
> > paths this now exposes.
>
> e.g:
> % debuginfod-find -v debuginfo /bin/ls
> [...]
> x-debuginfod-size: 502024
> x-debuginfod-archive: /mnt/fedora_koji_prod/koji/packages/coreutils/9.3/4.fc39/x86_64/coreutils-debuginfo-9.3-4.fc39.x86_64.rpm
> x-debuginfod-file: /usr/lib/debug/usr/bin/ls-9.3-4.fc39.x86_64.debug
> [...]
Ah, right. Thanks.
> > Does this include the temporary dir that a file is extracted in?
>
> No.
>
> > Does it really make sense to provide the full (absolute?) path of
> > the archive a source file was found in?
>
> As much sense as omitting the entire path information and returning
> only the basename. Sometimes the path may matter, if e.g. the archive
> file names are duplicate. And it turns out the archive paths were
> already usually sent in their entirety, and the archived-file paths
> were basename'd. Kinda the wrong way around. Anyway it's simplest to
> do neither bit of elision at the tool level.
OK. But I think you should add an explanation or example to "Front-end
proxies can also elide sensitive path name components" paragraph. So
the user is fully aware what those "sensitive path names" are. Maybe
even add that debuginfod-find -v example so people can double check.
Thanks,
Mark
next prev parent reply other threads:[~2023-10-11 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 20:37 Frank Ch. Eigler
2023-10-11 14:13 ` Mark Wielaard
2023-10-11 14:22 ` Frank Ch. Eigler
2023-10-11 14:50 ` Mark Wielaard [this message]
2023-10-11 18:57 ` Frank Ch. Eigler
2023-10-12 15:25 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb83dcee9b6110c92ac5086ff07f6f9360c03da9.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@elastic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).