From: Petr Machata <pmachata@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH 2/3] Simplify and inline get_uleb128 and get_sleb128
Date: Thu, 12 Dec 2013 23:23:11 +0100 [thread overview]
Message-ID: <m2r49hvhdc.fsf@redhat.com> (raw)
In-Reply-To: 52AA0932.6000704@redhat.com
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Josh Stone <jistone@redhat.com> writes:
> On 12/12/2013 04:13 AM, Petr Machata wrote:
>> Josh Stone <jistone@redhat.com> writes:
>>> +static inline uint64_t
>>> +__libdw_get_uleb128 (const unsigned char **addrp)
>>> +{
>>> + uint64_t acc = 0;
>>> + get_uleb128_step (acc, *addrp, 0);
>>> + for (unsigned int i = 1; i < len_leb128(acc); ++i)
>>> + get_uleb128_step (acc, *addrp, i);
>>
>> Is there a reason not to use for (i = 0; ...) instead of the pre-step
>> followed by a for (i = 1; ...)?
>
> Ah, yes, I should explain that a little. I found that the code was
> actually faster with the first step unrolled.
Ah, I think that's fine then, but needs a comment.
Thanks,
PM
next reply other threads:[~2013-12-12 22:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 22:23 Petr Machata [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 9:49 Mark Wielaard
2014-04-23 22:32 Petr Machata
2014-04-23 21:54 Mark Wielaard
2014-04-23 20:29 Petr Machata
2014-04-23 19:01 Josh Stone
2014-04-23 18:51 Richard Henderson
2014-04-23 18:32 Petr Machata
2014-04-23 15:27 Richard Henderson
2014-04-23 10:17 Petr Machata
2014-04-22 22:04 Mark Wielaard
2014-04-22 15:58 Richard Henderson
2014-04-22 15:52 Josh Stone
2014-04-22 15:03 Richard Henderson
2014-04-22 15:01 Richard Henderson
2014-04-22 14:55 Mark Wielaard
2013-12-12 19:06 Josh Stone
2013-12-12 12:13 Petr Machata
2013-12-11 1:35 Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r49hvhdc.fsf@redhat.com \
--to=pmachata@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).