From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100775 invoked by alias); 14 Nov 2019 13:55:02 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 100683 invoked by uid 89); 14 Nov 2019 13:55:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-15.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1200 X-Spam-Status: No, score=-15.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 13:55:00 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AAEADAD73 for ; Thu, 14 Nov 2019 13:54:58 +0000 (UTC) From: Andreas Schwab To: elfutils-devel@sourceware.org Subject: [PATCH] dwelf_elf_e_machine_string: Clear errno before calling strtol X-Yow: I like your SNOOPY POSTER!! Date: Thu, 14 Nov 2019 13:55:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-q4/txt/msg00134.txt.bz2 Avoid spurious failure if errno is modified by any other library call in the test. Signed-off-by: Andreas Schwab --- tests/ChangeLog | 5 +++++ tests/dwelf_elf_e_machine_string.c | 1 + 2 files changed, 6 insertions(+) diff --git a/tests/ChangeLog b/tests/ChangeLog index 97b8dedb..5b8a6224 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,8 @@ +2019-11-14 Andreas Schwab + + * dwelf_elf_e_machine_string.c (main): Clear errno before calling + strtol. + 2019-09-02 Mark Wielaard * run-readelf-s.sh: Add --dyn-syms case. diff --git a/tests/dwelf_elf_e_machine_string.c b/tests/dwelf_elf_e_machine_string.c index 1df2b233..afad1058 100644 --- a/tests/dwelf_elf_e_machine_string.c +++ b/tests/dwelf_elf_e_machine_string.c @@ -40,6 +40,7 @@ main (int argc, char **argv) int em; const char *machine; + errno = 0; if (strncmp ("0x", argv[i], 2) == 0) val = strtol (&argv[i][2], NULL, 16); else -- 2.24.0 -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."