From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 0408B385417F; Mon, 13 Feb 2023 17:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0408B385417F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1676310628; bh=HiSrxGspnvF2JyQxODVhUfLuULaERubMF46Nsdtaxoc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=jhmQarlNzbGqLfzyhXw1sNFxjroB2sOY8nET1729HSPJkRE5QVe15y6np0C7Uu8Dk Of4l2Z9X3ksWxiYSEcY2cS9WC4ex18BpsJ1W2K8Z0SHNbxL7aPfEVEToD6P8PHqosT mawlfAtAYwzkofWZeB3MzIpjL35x+DasGqnnrTxgUFZZZAVrzbRJT+E7aN92EDSbCN WGKFD5kkoaqntSaTGt045LVQC1b+G2x5pdumFMHI5Otcbtl2baPfdZtVIm17F6Zvz8 sTx9sLx4AeRE/Z/3GCVEqp+dzVYkWIjBZIZybG0Bhu3uJEFXa75ezRHUrM4XhwaDsy JOD2QdVWRTwgQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.80.251]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MuDbx-1oa4Vt3OIf-00uYE0; Mon, 13 Feb 2023 18:50:28 +0100 Message-ID: <0115618b-059b-fd11-a813-33374f16af78@gmx.de> Date: Mon, 13 Feb 2023 18:50:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Support for NOINLINE attribute To: Rimvydas Jasinskas Cc: fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cwOurEMUqb8LjLIAaZuZmMRtrGCqrEwIhs+DpwE+Woxi/DO7SRb PqbxzDAprSSQmmwkdF69g0p61STRtSbmubU2HSh9IzlxrDoTncY/038yiUxwjc5WnFTwETb Qbm+CFblkgVqnJcu/89PmYjXeoHpApoOwaSN7uTHhlLx87571wrh370ylWEI8VaEKstrhFK /9sQJ+bG/sHZaP0W4dcOg== UI-OutboundReport: notjunk:1;M01:P0:3dgu6uFa1TA=;eh0fS0DlpcOciMqQxRLL5Gd+ip2 v2yx1Gfz2+Q4hA/2Js5N5naMmZ+jmL1aGWAqe4ggWR4JCt4opY1LWQG1GO2rVyyP7Xm3WWeHl P5yEkh0UKG5w+ZmI6DnvZRU5oinougt/CEsNyEIEMFR8UCBOOWc7aEPpA8Gym3/NkEA8Wxe4o 4TqGvaSfJIHf9d2XtS0RMTQw3bCkyxdF6HW6FUw6RvtPuzjOw+FDXQofRdPeSLP8mHde1hUoz XZU59tjsY8D0KNggoBhOgPUW3MFBrl0AK3UnI8EEL9LkqpTuxAPsDQmpJfXcSf1yFf4S29U53 SVY1245rVLqkMaQJdVI0DjYEBdmRVpFmaHpzKwuKOaLkKPvH4quWCyUGY7mEUGciapqW/+ttS 5B4qoVxAXyj1HgPlIhrzhMeG6EmHXJiNzkgWmfV1kL4rm7Uy7iixPL4GIfnAWf6y7FoTSRJr8 F9dUtQjHkOtA9J82C/4bsZ6fAR6hFDRKw2EI/ud0MB5SHxdKnKDRPEswYjvjiyYnYF2ePh7DU fWnN3BFfJU0NOEWfEjiW1yGhnDLD9nKIjFwe8nxNS/cRI6l6Tr3J83IePvo5+fC+1LtPPQDZl bcrcnSxgSgEPOr2r4lMPpwOXMAuxDiM5JG87JY/B1UKZjKe6awQWFIXUj4m3OkAgqx3uG+g5D oBAmeThYEfQvGFHFGaL1zXKnUF9LydOond3cekMnodSZCGloL+BoNagpalKNV/a746A9hYcuH B4R4GAB9gRdmejryrO0qtVbrdQ+jotfXnU67HDk+3HHmqfXumtEYR4DYVP1UpeyTrs3YZZ/vC IsUTjJrceIeehEC1eEL7HylqB4mSp1sAFwy8cb4Zp0W9L2UyKKu7iElxbAxUFJ0hWOlKGRBR1 PRQV0E5RfruHQl7Dtxw2+t8ppwzC2s/9qTXA8oMEPvZy8XUtGYxIRY5SLbLotndHXnRSzpJ5w nkXiiA== X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed as: commit 086a1df4374962787db37c1f0d1bd9beb828f9e3 Thanks, Harald On 2/12/23 22:28, Harald Anlauf via Gcc-patches wrote: > Hi Rimvydas, > >> Gesendet: Sonntag, 12. Februar 2023 um 07:59 Uhr >> Von: "Rimvydas Jasinskas" >> An: "Harald Anlauf" >> Cc: "fortran" >> Betreff: Re: Support for NOINLINE attribute >> >> On Sat, Feb 11, 2023 at 11:26 PM Harald Anlauf wrote: >>> I am also not a native speaker, like many others contributing, but let >>> me quote the relevant orignal paragraph: >>> >>> "The @code{noreturn} keyword tells the compiler to assume that >>> @code{fatal} cannot return. It can then optimize without regard to wh= at >>> would happen if @code{fatal} ever did return. This makes slightly >>> better code. More importantly, it helps avoid spurious warnings of >>> uninitialized variables." >>> >>> My reading of this original paragraph differs very much from the >>> intention I get from the shortened version. Would you please reread? >>> >>>> Same, from extend.texi, see gcc/testsuite/gfortran.dg/noreturn-3.f90 >>>> It is about marking dead conditional branches, so that the compiler >>>> can prove proper initialization (no -Wmaybe-uninitialized given). It >>>> should behave the same as in C frontend. >>> >>> True. And that's the whole point (IMHO), not silencing the compiler. >> Hmm both look the same to me, the silencing of false positive >> diagnostics is already implied by spurious. To simplify I have >> changed it in v2 to just: >> "add a hint that a given function cannot return" documentation could >> be expanded later. >> >>> But shouldn't we rather follow what the C family of compilers in the >>> first place does for a particular target? Most relevant libraries >>> for Fortran code are either C/C++ or Fortran anyway, including any >>> of the common MPI implementations, so should we care about Ada? >> I agree with you. I have removed SUPPORTS_WEAK check and fixed >> indentation in v2. >> >> Regtested cleany on x86_64-pc-linux-gnu. >> >> Regards, >> Rimvydas > > this version of the patch looks good to me, so it is basically OK > to commit. > > There is one thing I cannot test, which is the handling of weak symbols > on other platforms. A quick glance at the C testcases suggests that > someone with access to either an NVPTX or MingGW target might tell > whether that particular target should be excluded. So I'd like to wait > for 24 hours for others to comment on this. > > I see that you've signed-off your patch. Do you have commit rights? > Otherwise I'll commit for you. (I've CC'ed to gcc-patches@ for this > purpose.) > > Thanks for the patch! > > Harald > > >