From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/87851 - [9/10/11/12 Regression] Wrong return type for len_trim
Date: Sun, 21 Nov 2021 12:46:01 +0100 [thread overview]
Message-ID: <02b4c4b8-8e3b-ff2e-e5ac-537c1c857380@orange.fr> (raw)
In-Reply-To: <trinity-8c340681-a917-4131-9801-344993efb907-1637351227189@3c-app-gmx-bap45>
Le 19/11/2021 à 20:47, Harald Anlauf via Fortran a écrit :
> Dear Fortranners,
>
> scalariziation of the elemental intrinsic LEN_TRIM was ICEing
> when the optional KIND argument was present.
>
> The cleanest solution is to use the infrastructure added by
> Mikael's fix for PR97896. In that case it is a 1-liner. :-)
>
> That fix is available on mainline and on 11-branch only, though.
> My suggestion is to fix the current PR only for the same branches,
> leaving the regression unfixed for older ones.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline and 11-branch?
>
Your change itself is fine.
The PR was originally about a type mismatch between the gfortran library
and the call generated by the front-end.
As the code generated contains a cast, I think it’s fine as well.
But please give Thomas (bug reporter) one more day to comment on this.
Then I think you can proceed.
Thanks.
next prev parent reply other threads:[~2021-11-21 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:47 Harald Anlauf
2021-11-21 11:46 ` Mikael Morin [this message]
2021-11-22 18:17 ` Harald Anlauf
2021-11-22 18:17 ` Harald Anlauf
2021-11-22 20:30 ` Bernhard Reutner-Fischer
2021-11-22 21:09 ` Harald Anlauf
2021-11-23 11:55 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02b4c4b8-8e3b-ff2e-e5ac-537c1c857380@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).