From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90835 invoked by alias); 13 Feb 2018 06:56:52 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 90825 invoked by uid 89); 13 Feb 2018 06:56:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=innocent, H*Ad:D*ie, H*F:D*ie, vimes X-HELO: mta05.svc.cra.dublin.eircom.net Received: from mta05.svc.cra.dublin.eircom.net (HELO mta05.svc.cra.dublin.eircom.net) (159.134.118.221) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 13 Feb 2018 06:56:50 +0000 Received: (qmail 48734 messnum 266834 invoked from network[213.94.190.14/avas02.vendorsvc.cra.dublin.eircom.net]); 13 Feb 2018 06:56:47 -0000 Received: from avas02.vendorsvc.cra.dublin.eircom.net (HELO avas02) (213.94.190.14) by mta05.svc.cra.dublin.eircom.net (qp 48734) with SMTP; 13 Feb 2018 06:56:47 -0000 Received: from mail.sceal.ie ([83.70.207.66]) by Cloudmark Gateway with SMTP id lUWFea2eTBt3blUWFe2jEm; Tue, 13 Feb 2018 06:56:47 +0000 X-CNFS-Analysis: v=2.2 cv=U5fiNaju c=1 sm=1 tr=0 a=0Iw1gYdl+gX5BU/pizvEUA==:117 a=0Iw1gYdl+gX5BU/pizvEUA==:17 a=IkcTkHD0fZMA:10 a=Op4juWPpsa0A:10 a=xNf9USuDAAAA:8 a=Ug2Xn3OAAAAA:8 a=1spb2K-7wh_e4UpK9QoA:9 a=QEXdDO2ut3YA:10 a=SEwjQc04WA-l_NiBhQ7s:22 a=jup2QEcnA-U7-sUVP0FS:22 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.sceal.ie (Postfix) with ESMTP id E5B0916A57B; Tue, 13 Feb 2018 06:56:46 +0000 (GMT) Received: from mail.sceal.ie ([127.0.0.1]) by localhost (mail.sceal.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WgprwvyMAvNY; Tue, 13 Feb 2018 06:56:45 +0000 (GMT) Received: from Alastairs-Laptop.local (dsl-fixed-94-30-55-205.interdsl.co.uk [94.30.55.205]) by mail.sceal.ie (Postfix) with ESMTPSA id 7C55A160F13; Tue, 13 Feb 2018 06:56:45 +0000 (GMT) Subject: Re: Bit-reproduciblity issue for gfortran .mod files To: Janne Blomqvist , Alastair McKinstry Cc: Fortran List References: <4bf5bd17-616d-06ad-f6b6-e8a253c60ed7@debian.org> <20180203015813.GA10720@troutmask.apl.washington.edu> <5be51114-0461-f996-9860-b1c309fcb267@sceal.ie> From: Alastair McKinstry Message-ID: <032a646b-bb87-a6e4-7cf4-2d2470e8ea90@sceal.ie> Date: Tue, 13 Feb 2018 06:56:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfK7QgZwS7ciOGZIxPLtB0j6GXizTLww9PnEvfPEH3slOsZ+OaC01BwzUQaH8av7FXmajCqgOqkYjy1SjHYCcry2t6CpJIGntQyKo1w/A7l+yj0D36fzJ P8mafVy9H0J8dG5V4l+SbZXJmJDyhSTxCOut6eZdkiKAhNHWF/EeYBU3V1AIEVCzB7QppkdLyfJ0LuJkgVI7NCtkt4lI1FCC1B8= X-SW-Source: 2018-02/txt/msg00077.txt.bz2 >>> So while reproducible builds are important and this is a good catch, >>> your patch as-is is not really usable. But luckily gcc includes a copy >>> of libiberty, including lbasename(). That function seems to be used by >>> other frontends, so I'd suggest using that instead. >> Thanks, I hadn't heard of lbasename(). I've just tested it and it works. >> No header inclusion needed. > This is Ok for trunk with a proper ChangeLog entry. Since it's > effectively a change in a comment I think we can dispense with nagging > the release managers, even though we're in stage 4. > > Do you, or anybody else, have any particular opinion on whether it > should be backported to older release branches? > > Do you have commit access, or do you need somebody to do it for you? > I have no opinion on whether it should be backported; there is a patch for it in Debian at the moment; it would help reproducible builds elsewhere (eg OpenSUSE have a reproducible builds project too). I don't have commit access. -- Alastair McKinstry, , , https://diaspora.sceal.ie/u/amckinstry Commander Vimes didn’t like the phrase “The innocent have nothing to fear,” believing the innocent had everything to fear, mostly from the guilty but in the longer term even more from those who say things like “The innocent have nothing to fear.” - T. Pratchett, Snuff