From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: error recovery on invalid array reference of non-array [PR103590]
Date: Tue, 19 Jul 2022 11:03:36 +0200 [thread overview]
Message-ID: <0342ad62-3f9c-4fbb-bd00-f4d4a6b49fc7@orange.fr> (raw)
In-Reply-To: <trinity-ef3d4164-ec7e-4065-bf70-9bf23de6d02e-1658176984284@3c-app-gmx-bap07>
Hello,
the principle looks good, but...
Le 18/07/2022 à 22:43, Harald Anlauf via Fortran a écrit :
> diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
> index 2ebf076f730..dacd33561d0 100644
> --- a/gcc/fortran/resolve.cc
> +++ b/gcc/fortran/resolve.cc
> @@ -5004,7 +5004,11 @@ find_array_spec (gfc_expr *e)
> {
> case REF_ARRAY:
> if (as == NULL)
> - gfc_internal_error ("find_array_spec(): Missing spec");
> + {
> + gfc_error ("Symbol %qs at %L has not been declared as an array",
> + e->symtree->n.sym->name, &e->where);
... the error here only makes sense if the array reference follows a
variable reference. If it follows a derived type component reference, a
slightly different error message would be more appropriate.
next prev parent reply other threads:[~2022-07-19 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 20:43 Harald Anlauf
2022-07-19 9:03 ` Mikael Morin [this message]
2022-07-19 19:09 ` Harald Anlauf
2022-07-19 19:09 ` Harald Anlauf
2022-07-19 20:53 ` Mikael Morin
2022-07-19 21:34 ` Harald Anlauf
2022-07-19 21:34 ` Harald Anlauf
2022-07-20 9:40 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0342ad62-3f9c-4fbb-bd00-f4d4a6b49fc7@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).