From: Jerry DeLisle <jvdelisle@charter.net>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: gscfq@t-online.de
Subject: Re: [Patch, fortran] PR82586 - [PDT] ICE: write_symbol(): bad module symbol
Date: Fri, 20 Oct 2017 22:38:00 -0000 [thread overview]
Message-ID: <0586bb38-1989-3fa2-6fdf-cb5c4ff88086@charter.net> (raw)
In-Reply-To: <CAGkQGiKp_hOHEGG7Kv=ao0ZMZfrTvvL4euXR-Ws_NK0V+BEKsQ@mail.gmail.com>
On 10/20/2017 11:55 AM, Paul Richard Thomas wrote:
> Dear All,
>
> In the last hour, I have added fixes for PRs 82587 and 82589. Please
> review them together with 82586.
>
> I will stop work on Gerhard's PDT bugs until this patch is committed.
> Fortunately, Steve Kargl has proposed fixes for most of them :-)
>
> Cheers
>
> Paul
>
> 2017-10-20 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/82586
> * decl.c (gfc_get_pdt_instance): Remove the error message that
> the parameter does not have a corresponding component since
> this is now taken care of when the derived type is resolved. Go
> straight to error return instead.
> (gfc_match_formal_arglist): Make the PDT relevant errors
> immediate so that parsing of the derived type can continue.
> (gfc_match_derived_decl): Do not check the match status on
> return from gfc_match_formal_arglist for the same reason.
> * resolve.c (resolve_fl_derived0): Check that each type
> parameter has a corresponding component.
>
> PR fortran/82587
> * resolve.c (resolve_generic_f): Check that the derived type
> can be used before resolving the struture constructor.
>
> PR fortran/82589
> * symbol.c (check_conflict): Add the conflicts involving PDT
> KIND and LEN attributes.
>
> 2017-10-20 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/82586
> * gfortran.dg/pdt_16.f03 : New test.
> * gfortran.dg/pdt_4.f03 : Catch the changed messages.
> * gfortran.dg/pdt_8.f03 : Ditto.
>
> PR fortran/82587
> * gfortran.dg/pdt_17.f03 : New test.
>
> PR fortran/82589
> * gfortran.dg/pdt_18.f03 : New test.
>
> On 20 October 2017 at 18:17, Paul Richard Thomas
> <paul.richard.thomas@gmail.com> wrote:
>> Dear All,
>>
>> The attached patch is pretty clear with the ChangeLogs and is very
>> nearly obvious.
>>
>> Bootstrapped and regtested on FC23/x86_64 - OK for trunk?
>>
>> Paul
Looks Good to me. OK for trunk.
Jerry
PS The previous patch as well.
>>
>> 2017-10-20 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/82586
>> * decl.c (gfc_get_pdt_instance): Remove the error message that
>> the parameter does not have a corresponding component since
>> this is now taken care of when the derived type is resolved. Go
>> straight to error return instead.
>> (gfc_match_formal_arglist): Make the PDT relevant errors
>> immediate so that parsing of the derived type can continue.
>> (gfc_match_derived_decl): Do not check the match status on
>> return from gfc_match_formal_arglist for the same reason.
>> * resolve.c (resolve_fl_derived0): Check that each type
>> parameter has a corresponding component.
>>
>> 2017-10-20 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/82586
>> * gfortran.dg/pdt_16.f03 : New test.
>> * gfortran.dg/pdt_4.f03 : Catch the changed messages.
>> * gfortran.dg/pdt_8.f03 : Ditto.
>>
>>
>> --
>> "If you can't explain it simply, you don't understand it well enough"
>> - Albert Einstein
>
>
>
prev parent reply other threads:[~2017-10-20 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:17 Paul Richard Thomas
2017-10-20 18:55 ` Paul Richard Thomas
2017-10-20 19:17 ` Steve Kargl
2017-10-20 22:39 ` Jerry DeLisle
2017-10-20 22:38 ` Jerry DeLisle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0586bb38-1989-3fa2-6fdf-cb5c4ff88086@charter.net \
--to=jvdelisle@charter.net \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gscfq@t-online.de \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).