From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3908 invoked by alias); 20 Oct 2017 22:38:16 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 3891 invoked by uid 89); 20 Oct 2017 22:38:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:2017102, H*RU:sk:2017102, H*M:1989, Hx-languages-length:2937 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout004-public.msg.strl.va.charter.net Received: from mtaout004-public.msg.strl.va.charter.net (HELO mtaout004-public.msg.strl.va.charter.net) (68.114.190.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 22:38:14 +0000 Received: from impout002 ([68.114.189.17]) by mtaout004.msg.strl.va.charter.net (InterMail vM.9.00.023.01 201-2473-194) with ESMTP id <20171020223812.HOMI3685.mtaout004.msg.strl.va.charter.net@impout002>; Fri, 20 Oct 2017 17:38:12 -0500 Received: from amda8.localdomain ([96.41.213.35]) by impout002 with charter.net id PyeB1w0030mPCJg01yeBBc; Fri, 20 Oct 2017 17:38:12 -0500 X-Authority-Analysis: v=2.2 cv=C6eZ8UH+ c=1 sm=1 tr=0 a=NNeuWy7OTYa7gJ+3pFFB5Q==:117 a=NNeuWy7OTYa7gJ+3pFFB5Q==:17 a=IkcTkHD0fZMA:10 a=x7bEGLp0ZPQA:10 a=mDV3o1hIAAAA:8 a=pGLkceISAAAA:8 a=Jqr5TZaogaHuwrbrN24A:9 a=Hl0LzWn_DPY57jr3:21 a=qNiKX_WPcyqBU0Ir:21 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Auth-id: anZkZWxpc2xlQGNoYXJ0ZXIubmV0 Subject: Re: [Patch, fortran] PR82586 - [PDT] ICE: write_symbol(): bad module symbol To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Cc: gscfq@t-online.de References: From: Jerry DeLisle Message-ID: <0586bb38-1989-3fa2-6fdf-cb5c4ff88086@charter.net> Date: Fri, 20 Oct 2017 22:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00091.txt.bz2 On 10/20/2017 11:55 AM, Paul Richard Thomas wrote: > Dear All, > > In the last hour, I have added fixes for PRs 82587 and 82589. Please > review them together with 82586. > > I will stop work on Gerhard's PDT bugs until this patch is committed. > Fortunately, Steve Kargl has proposed fixes for most of them :-) > > Cheers > > Paul > > 2017-10-20 Paul Thomas > > PR fortran/82586 > * decl.c (gfc_get_pdt_instance): Remove the error message that > the parameter does not have a corresponding component since > this is now taken care of when the derived type is resolved. Go > straight to error return instead. > (gfc_match_formal_arglist): Make the PDT relevant errors > immediate so that parsing of the derived type can continue. > (gfc_match_derived_decl): Do not check the match status on > return from gfc_match_formal_arglist for the same reason. > * resolve.c (resolve_fl_derived0): Check that each type > parameter has a corresponding component. > > PR fortran/82587 > * resolve.c (resolve_generic_f): Check that the derived type > can be used before resolving the struture constructor. > > PR fortran/82589 > * symbol.c (check_conflict): Add the conflicts involving PDT > KIND and LEN attributes. > > 2017-10-20 Paul Thomas > > PR fortran/82586 > * gfortran.dg/pdt_16.f03 : New test. > * gfortran.dg/pdt_4.f03 : Catch the changed messages. > * gfortran.dg/pdt_8.f03 : Ditto. > > PR fortran/82587 > * gfortran.dg/pdt_17.f03 : New test. > > PR fortran/82589 > * gfortran.dg/pdt_18.f03 : New test. > > On 20 October 2017 at 18:17, Paul Richard Thomas > wrote: >> Dear All, >> >> The attached patch is pretty clear with the ChangeLogs and is very >> nearly obvious. >> >> Bootstrapped and regtested on FC23/x86_64 - OK for trunk? >> >> Paul Looks Good to me. OK for trunk. Jerry PS The previous patch as well. >> >> 2017-10-20 Paul Thomas >> >> PR fortran/82586 >> * decl.c (gfc_get_pdt_instance): Remove the error message that >> the parameter does not have a corresponding component since >> this is now taken care of when the derived type is resolved. Go >> straight to error return instead. >> (gfc_match_formal_arglist): Make the PDT relevant errors >> immediate so that parsing of the derived type can continue. >> (gfc_match_derived_decl): Do not check the match status on >> return from gfc_match_formal_arglist for the same reason. >> * resolve.c (resolve_fl_derived0): Check that each type >> parameter has a corresponding component. >> >> 2017-10-20 Paul Thomas >> >> PR fortran/82586 >> * gfortran.dg/pdt_16.f03 : New test. >> * gfortran.dg/pdt_4.f03 : Catch the changed messages. >> * gfortran.dg/pdt_8.f03 : Ditto. >> >> >> -- >> "If you can't explain it simply, you don't understand it well enough" >> - Albert Einstein > > >