From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id A1C643858D28; Fri, 7 Apr 2023 09:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1C643858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680860423; i=anlauf@gmx.de; bh=I6zu7LvqUrbyuPHnM9QfpBinTrqMlTOfubFbTfFPy4o=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=uZ3dBy8RDTLzZNOiijEyQ/Tx0YJz1wg7vLNjnCMFxhXajbUDbWFzvrAMLfX8A/9nu 6z+yfHDljRNSAUQ/ExfcsOQjyqQRFYrQTaD2h9Sc/klvudTUif/F2/3aaMchFQedfk kz+N5ulBcRABvv9yzVdnoEWLFR9VpS/wsnSSyksoM0PyvWc/yhYM0r0s+lCu4UNSB4 /8DaGJiThoWGTtafOP2m8lYW5OmAP6i+NcZl5E85KXBydKnziRJhOP2sressga81wf LACgPgPfgmWMvTCCPTyb5Dr8hcBKimRE3EClyTkT7JJo2wbPxxlmvNN4D1IkukyLrD 3F+v6qlkoUXAQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.89.174]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MacSY-1qH2Wj116Q-00c6Ir; Fri, 07 Apr 2023 11:40:23 +0200 Message-ID: <06e9fe56-4314-3392-389c-57ffd74844ab@gmx.de> Date: Fri, 7 Apr 2023 11:40:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [Patch, fortran] PR87477 - [meta-bug] [F03] issues concerning the ASSOCIATE statement To: Paul Richard Thomas , Manfred Schwarb Cc: gcc-patches , "fortran@gcc.gnu.org" Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <0a9997a2-819e-40bc-4623-a4dbd3507a32@gmx.ch> Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SL+tU5MQBoBzMBcZSG5J2a0uEtF9IYF/i2NibcRHuoFiA83d/0D YVc0pQTzyboYBxj84RkCcoVUjgtrxoI/s3D3zr76OJ9mHoFK9OUlyVTHeZMXN/yXeFTadjY T3Rel8zGbiaIQ0PgQtaK1NZXFa/24DsU3QSm1U8wgzmf+t05SnGHHaKmFsVRzMvadqDdHvP 5L9CoMt8wn0LSoTgeThDg== UI-OutboundReport: notjunk:1;M01:P0:RqG9egZJAo0=;rIrlahkwygLG4pEnIUFLxuLkuA6 MtYMkZu/xYYjmMHAHPq0XKWW51HU8S/Nebn7BS7ILJ0tm196f3jvNfuTylrwDpl9h2QfvFc+v rVLh1l9E234f7/1MnaLLAQpF2wAa9ggNraV7Al9+FfisTb8gceCeNoVhte9aAkp2xI9ZOd7qY c8Dj4X+XEmWeO71aYkhnfQLljYWRgQjX2aIJOmGb+nJq11valkt9/7a1AgJsBfpCHkvEctU7k yyZ/RKreKXFlxkuyEYgpjysG2P1ovR1AmGgHPApY0d903EL38+yhGIiQqjoVbrK9CtmwL1MRj gwDVNNSnk/RGSqOmcYuZOI30vqarn3qpwl+2NMt4D3ba+1fDlowtlKZ5b+hHDJwC7FD8OH+bA DIRF4Hl3oN20TdqDX3IbFXwbgXaaSlX4fhmWmQrTGvDk0chIVEPoDyYkrSsy1sSlUtA5/dEVd Ycd+BS75r1I6iZyeO88gkBG3TW3lxEv1Vb/sgxRbBcQbTzOu0tXlU6Z82m7Inyf4mb32Q/JjC zJSbdr7r6yiQ3K8Vteigu8FXsi/luHj+p9SGjN439JxNXeblmtWw6Yd7I0GFUiU718dZ6xJWo eou8V4QfXKVYL2c569MWq+I8pAU6YgOaQpjr3hoOEbAx5lhvKrCGMihI77802cfNvL8SIK9qa /RX1G7oQruQkp+cLw+n7R0dBqyBn+R/ekmNLuKzaQbKwyr5o/aCVyGLtGiGz9HrX+fgYiIfwg dWKW6IqvuIQjNFP8rjbFkUC6LQshYU6UTqbtKPbVeBywo8oy6sCHvHF6oiJgmMz/J64Ylcj+T i5WSG/pFt1/8hRpPNs6GXcK213KXI5P19s7PK90sK83HngRndu0zGQlGacxlDzur3jxdi4vPQ nutrStfD0AaLAAUoSe301ZvYFKkcT/cMYLzyOMLpLrZ7WvAkw4p8C2vIPJCBDr8zN4P5yD2od 8HWuWBF53py+9GqEBOWzfCmKPt8= X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, On 4/7/23 09:02, Paul Richard Thomas via Gcc-patches wrote: > Hi All, > > Please find attached the patch to fix the dg directives and remove a lot= of > trailing white space. > > Unless there are any objections, I will commit as obvious over the weeke= nd. this is OK. Thanks for the patch! Harald > Cheers > > Paul > > Fortran: Fix dg directives and remove trailing whitespaces in testsuite > > 2023-04-07 Paul Thomas > > * gfortran.dg/c-interop/allocatable-optional-pointer.f90 : Fix > dg directive and remove trailing whitespace. > * gfortran.dg/c-interop/c407a-1.f90 : ditto > * gfortran.dg/c-interop/c407b-1.f90 : ditto > * gfortran.dg/c-interop/c407b-2.f90 : ditto > * gfortran.dg/c-interop/c407c-1.f90 : ditto > * gfortran.dg/c-interop/c535a-1.f90 : ditto > * gfortran.dg/c-interop/c535a-2.f90 : ditto > * gfortran.dg/c-interop/c535b-1.f90 : ditto > * gfortran.dg/c-interop/c535b-2.f90 : ditto > * gfortran.dg/c-interop/c535b-3.f90 : ditto > * gfortran.dg/c-interop/c535c-1.f90 : ditto > * gfortran.dg/c-interop/c535c-2.f90 : ditto > * gfortran.dg/c-interop/deferred-character-1.f90 : ditto > * gfortran.dg/c-interop/removed-restrictions-1.f90 : ditto > * gfortran.dg/c-interop/removed-restrictions-2.f90 : ditto > * gfortran.dg/c-interop/removed-restrictions-4.f90 : ditto > * gfortran.dg/c-interop/tkr.f90 : ditto > * gfortran.dg/class_result_10.f90 : ditto > * gfortran.dg/dtio_35.f90 : ditto > * gfortran.dg/goacc/array-with-dt-2.f90 : ditto > * gfortran.dg/gomp/affinity-clause-1.f90 : ditto > * gfortran.dg/pr103258.f90 : ditto > * gfortran.dg/pr59107.f90 : ditto > * gfortran.dg/pr93835.f08 : ditto > > > > On Wed, 29 Mar 2023 at 09:53, Paul Richard Thomas < > paul.richard.thomas@gmail.com> wrote: > >> Hi Manfred, >> >> Indeed I do :-) Thanks for the spot. I have decided that it will be les= s >> messy if I roll all the testcases into one or, perhaps two =3D> >> associate_xx.f90 >> >> Forgetting the space before the final brace seems to be rife! >> >> Cheers >> >> Paul >> >> >> On Wed, 29 Mar 2023 at 09:24, Manfred Schwarb wrote: >> >>> Am 28.03.23 um 23:04 schrieb Paul Richard Thomas via Fortran: >>>> Hi All, >>>> >>>> I have made a start on ASSOCIATE issues. Some of the low(-ish) hangin= g >>>> fruit are already fixed but I have yet to check that they a really fi= xed >>>> and to close them: >>>> pr102106, pr102111, pr104430, pr106048, pr85510, pr87460, pr92960 & >>> pr93338 >>>> >>>> The attached patch picks up those PRs involving deferred length >>> characters >>>> in one guise or another. I believe that it is all pretty >>> straightforward. >>>> Structure constructors with allocatable, deferred length, character >>> array >>>> components just weren't implemented and so this is the biggest part o= f >>> the >>>> patch. I found two other, non-associate PRs(106918 & 105205) that ar= e >>>> fixed and there are probably more. >>>> >>>> The chunk in trans-io.cc is something of a kludge, which I will come >>> back >>>> to. Some descriptors come through with a data pointer that looks as i= f >>> it >>>> should be OK but >>>> >>>> I thought to submit this now to get it out of the way. The ratio of P= Rs >>>> fixed to the size of the patch warrants this. The next stage is going >>> to be >>>> rather messy and so "I might take a little while" (cross talk between >>>> associate and select type, in particular). >>>> >>>> Regtests OK - good for mainline? >>>> >>> >>> Paul, you have some "dg-do-run" and "dg-do-compile" statements in your >>> testcases, >>> could you change them into their single-minus-sign variants? >>> >>> Cheers, >>> Manfred >>> >>> >>> BTW: I just ran my script again and found the following testsuite issu= es >>> (note that outer-most >>> braces need to be space-padded): >>> >>> ./c-interop/removed-restrictions-1.f90:! { dg-do compile} >>> ./c-interop/removed-restrictions-2.f90:! { dg-do compile} >>> ./c-interop/removed-restrictions-3.f90:! { dg-do compile} >>> ./c-interop/removed-restrictions-4.f90:! { dg-do compile} >>> ./c-interop/tkr.f90:! { dg-do compile} >>> ./c-interop/c407c-1.f90:! { dg-do compile} >>> ./c-interop/deferred-character-1.f90:! { dg-do compile} >>> ./c-interop/allocatable-optional-pointer.f90:! { dg-do compile} >>> ./c-interop/c407a-1.f90:! { dg-do compile} >>> ./c-interop/c407b-1.f90:! { dg-do compile} >>> ./c-interop/c407b-2.f90:! { dg-do compile} >>> ./c-interop/c535a-1.f90:! { dg-do compile} >>> ./c-interop/c535a-2.f90:! { dg-do compile} >>> ./c-interop/c535b-1.f90:! { dg-do compile} >>> ./c-interop/c535b-2.f90:! { dg-do compile} >>> ./c-interop/c535b-3.f90:! { dg-do compile} >>> ./c-interop/c535c-1.f90:! { dg-do compile} >>> ./c-interop/c535c-2.f90:! { dg-do compile} >>> ./gomp/affinity-clause-1.f90:! { dg final { scan-tree-dump-times "#pra= gma >>> omp task affinity\\(iterator\\(integer\\(kind=3D4\\) >>> i=3DD\\.\[0-9\]+:5:1\\):b\\\[\\(.* ? \\+ -1\\\]\\) >>> affinity\\(iterator\\(integer\\(kind=3D4\\) >>> i=3DD\\.\[0-9\]+:5:1\\):d\\\[\\(\\(integer\\(kind=3D8\\)\\) i \\+ -1\\= ) \\* >>> 6\\\]\\)" 1 "original" } } >>> ./class_result_10.f90:! { dg-do run} >>> ./pr103258.f90:! { dg-do compile} >>> ./dtio_35.f90:! { dg-compile } >>> ./pr93835.f08:! {dg-do run } >>> ./pr59107.f90:! { dg-compile } >>> >>> >>> >>>> Cheers >>>> >>>> Paul >>>> >>>> Fortran: Fix some of the bugs in associate [PR87477] >>>> >>>> 2023-03-28 Paul Thomas >>>> >>>> gcc/fortran >>>> PR fortran/87477 >>>> * trans-array.cc (gfc_conv_expr_descriptor): Guard string len >>>> expression in condition. >>>> (duplicate_allocatable): Make element type more explicit with >>>> 'eltype'. >>>> * trans-expr.cc (gfc_get_expr_charlen): Retain last charlen in >>>> 'previous' and use if end expression in substring reference is >>>> null. >>>> (gfc_conv_string_length): Use gfc_conv_expr_descriptor if >>>> 'expr_flat' is an array. >>>> (gfc_trans_alloc_subarray_assign): If this is a deferred string >>>> length component, store the string length in the hidden comp. >>>> Update the typespec length accordingly. Generate a new type >>>> spec for the call to gfc_duplicate-allocatable in this case. >>>> * trans-io.cc (gfc_trans_transfer): Scalarize transfer of >>>> deferred character array components. >>>> >>>> >>>> gcc/testsuite/ >>>> PR fortran/92994 >>>> * gfortran.dg/finalize_51.f90 : Update an error message. >>>> >>>> PR fortran/85686 >>>> * gfortran.dg/pr85686.f90 : New test >>>> >>>> PR fortran/88247 >>>> * gfortran.dg/pr88247.f90 : New test >>>> >>>> PR fortran/91941 >>>> * gfortran.dg/pr91941.f90 : New test >>>> >>>> PR fortran/92779 >>>> * gfortran.dg/pr92779.f90 : New test >>>> >>>> PR fortran/93339 >>>> * gfortran.dg/pr93339.f90 : New test >>>> >>>> PR fortran/93813 >>>> * gfortran.dg/pr93813.f90 : New test >>>> >>>> PR fortran/100948 >>>> * gfortran.dg/pr100948.f90 : New test >>>> >>>> PR fortran/102106 >>>> * gfortran.dg/pr102106.f90 : New test >>>> >>>> PR fortran/105205 >>>> * gfortran.dg/pr105205.f90 : New test >>>> >>>> PR fortran/106918 >>>> * gfortran.dg/pr106918.f90 : New test >>> >>> >> >> -- >> "If you can't explain it simply, you don't understand it well enough" - >> Albert Einstein >> > >