From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id BEA743858D33; Wed, 15 Mar 2023 09:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEA743858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="101673235" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 15 Mar 2023 01:10:50 -0800 IronPort-SDR: c4sJA4HOTtJ2SloAFLjpIR+Nh072jOIOsqWewFMRP9eX7//5MrIfTvkvsePS63V/bhUbu0LD3V vuH2ZhblMbzxb9sso8Y0FVUwxD5Z93XhZ1UeIJhPXL3OoI06Bh9UU1FiMqXN2TIs/833F1kP1n MU0oAAJsEmzNnxR3xjIo+5cVi3MsLmO1GK1KE6xUELVlhD3Nzk9jgE0J9K8v/EYZNea/DiX6R1 /zwz09V6s4dycXtPDH+qs91OklM9xqss2z8o6qTAe+rLhdlSsYjqeVg56QbVl75UixbeUrH2e6 cLA= Message-ID: <099717a7-2de0-c71a-f9fa-58095e691898@codesourcery.com> Date: Wed, 15 Mar 2023 10:10:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Fortran: rank checking with explicit-/assumed-size arrays and CLASS [PR58331] Content-Language: en-US To: Harald Anlauf , fortran CC: gcc-patches References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Harald, On 14.03.23 20:38, Harald Anlauf wrote: > The testcase covers only non-coarray cases, as playing with > coarray variants hit pre-exisiting issues in gfortran that > are very likely unrelated to the interface checks. I concur (but would not rule out additional interface issues). > I consider this rather as post 13-release stuff. In any case, the coarray issue can be fixed separately. And I think post-GCC-13 makes sense. > Regtested on x86_64-pc-linux-gnu. OK for mainline? Thanks =E2=80=93 LGTM! > + formal_as =3D formal->ts.type =3D=3D BT_CLASS ? CLASS_DATA (formal)->a= s > + : formal->as; > + (Jakub remarks for such code that some editor (emacs?), he does not use, mis--auto-indent such a code - and proposes to add a parentheses around the right-hand side of the assignment.) * * * I also wonder whether we need some run-time testcase. The interface check now works and I also tend to write dg-do-compile testcases, but given what can go wrong with all the array descriptor, class etc handling, we may want to ensure it works at run time. =E2=80=93 Thoughts? (That's independent of the patch it and could be done as follow up, if it deemed reasonable. The included testcase is surely compile-only as it has dg-error checks.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955