From: Jerry D <jvdelisle2@gmail.com>
To: Andrew Pinski <pinskia@gmail.com>, Harald Anlauf <anlauf@gmx.de>
Cc: fortran <fortran@gcc.gnu.org>, Jerry D <jvdelisle2@gmail.com>
Subject: Re: Invalid "dg-do run" in the testsuite (with 2 blanks)
Date: Tue, 2 Apr 2024 10:44:52 -0700 [thread overview]
Message-ID: <0bd9366f-c91e-4c00-9811-0f4e196f7fa5@gmail.com> (raw)
In-Reply-To: <CA+=Sn1=jkm7mNSmwcqA4K1-YeYdrTRcKLQMhdZRBzr0iznconQ@mail.gmail.com>
On 4/1/24 11:46 PM, Andrew Pinski wrote:
> On Sun, Mar 24, 2024 at 1:19 PM Harald Anlauf <anlauf@gmx.de> wrote:
>>
>> Dear all,
>>
>> I noticed by chance that we have quite a lot of improperly specified do-do
>> directives in the testsuite.
>>
>> % grep "dg-do run" gcc/testsuite/gfortran.dg/ -rl|wc -l
>> 83
>>
>> Note that with two blanks instead of just one a testcase does not get executed.
>>
>> Does anybody want to earn the honors to change the directives and
>> check for "fallout" in the testsuite?
>
> Note this seems related to
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=28032 (or maybe this is
> the "workaround" for not doing torture options on the testcases).
>
> If this gets documented to avoid doing the torture options, then the
> testsuite should be auditted for dg-options with `-ON` and add the
> extra space for dg-do to get the non torture way.
>
> Thanks,
> Andrew
>
>>
>> Cheers,
>> Harald
>>
Thanks for this additional info. I have not settled on exactly what to say in the documentation.
I noticed that when I specified a specific -ON it still did them all regardless. I did not know if this was expected or a feature.
Jerry -
prev parent reply other threads:[~2024-04-02 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 20:19 Harald Anlauf
2024-03-24 23:26 ` Jerry D
2024-03-25 4:53 ` Jerry D
2024-03-25 8:27 ` Manfred Schwarb
2024-03-25 17:38 ` Jerry D
2024-03-25 19:53 ` Harald Anlauf
2024-03-25 20:52 ` Jerry D
2024-03-25 22:30 ` Aw: " Harald Anlauf
2024-03-26 1:24 ` Jerry D
2024-03-26 7:49 ` Richard Biener
2024-03-26 8:53 ` Mikael Morin
2024-04-02 6:46 ` Andrew Pinski
2024-04-02 17:44 ` Jerry D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd9366f-c91e-4c00-9811-0f4e196f7fa5@gmail.com \
--to=jvdelisle2@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).