From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id CB3FC3858C83 for ; Tue, 26 Apr 2022 20:04:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB3FC3858C83 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1njRQR-000A7x-6v for fortran@gcc.gnu.org; Tue, 26 Apr 2022 22:04:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH v2] fortran: Avoid infinite self-recursion [PR105381] Date: Tue, 26 Apr 2022 22:04:38 +0200 Message-ID: <0c43264f-a8f4-9860-8282-f2d60cf2da2a@gmx.de> References: <8f082ce4-a6a9-72c1-a882-4663426adaff@orange.fr> <4567d0f0-3077-d582-e2d2-b0169c322009@codesourcery.com> <737d7a95-33f0-4264-4ba7-caed687c3092@orange.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 20:04:46 -0000 Hi Mikael, Am 26.04.22 um 21:10 schrieb Mikael Morin: > Le 26/04/2022 à 19:12, Mikael Morin a écrit : >> Le 26/04/2022 à 15:32, Jakub Jelinek a écrit : >>> or one can repeat it like: >>>      if (DECL_P (expr) >>>     && DECL_LANG_SPECIFIC (expr) >>>     && GFC_DECL_SAVED_DESCRIPTOR (expr) >>>     && GFC_DECL_SAVED_DESCRIPTOR (expr) != expr) >>>        return non_negative_strides_array_p (GFC_DECL_SAVED_DESCRIPTOR >>> (expr)); >> >> I think I’ll use that. > > Here it comes. > Regression tested again. OK? works for me. Thanks for the quick fix! Harald From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 61D743858403; Tue, 26 Apr 2022 20:04:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61D743858403 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.81.12]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfYLQ-1oKy5w1iWm-00g4JK; Tue, 26 Apr 2022 22:04:40 +0200 Message-ID: <0c43264f-a8f4-9860-8282-f2d60cf2da2a@gmx.de> Date: Tue, 26 Apr 2022 22:04:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] fortran: Avoid infinite self-recursion [PR105381] Content-Language: en-US To: Mikael Morin , Jakub Jelinek , Tobias Burnus Cc: gcc-patches , gfortran Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <8f082ce4-a6a9-72c1-a882-4663426adaff@orange.fr> <4567d0f0-3077-d582-e2d2-b0169c322009@codesourcery.com> <737d7a95-33f0-4264-4ba7-caed687c3092@orange.fr> From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:d7S2CTlW3eMSOfs2IoybScSKDuZLXqaOoqvtrEz8pYdyol2Pmp5 lu3yWQM1o/OEHEjoTQR2flilAxhyhJMWupg89VyRGLiV8O+bZNPMwgu5Pl7jrI9MfAiPVXb Xh5GFKFwbJGeUrDbBBZJMde63yXC1QPgjAZWUo8EH1fRcC5YUieGIkccQyDuGyFGkhqLJH0 AL85dJFHq4oZ3RL66hE4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:8VUMLip0Ggo=:C6eNn8lXWtgqX/2bNYEJVF u0XUsnduPKlMWfEpeL8qmrBI1eI5FN0cqMbC8P2kNliOkQXSFqmojaXUn8r2bgYjjGybnhM7E SEmo8tFMzRTmrUCCIaaVWYq1Igb7PN5Y+njzMXisKFkL5wOCIrFBjltc8YI2rzaWfBzCEe9hf d/683nw+q3Ehrn0GBehaxrdlvbXY4AxaCUh3gjD2l0Qnh8m7Gdfk1CDTt7/Axw4nTnlnzsFNF W+XdjwzIzmJTT8nhgTlvVrYsz4KZVYICgdeV8HY9SP4mu0yWqxZDRxL68FdyqTP6DftQbS1jz U3mWnER8O1KgJwCIt4+1OP5ngc3TIx3QuotKU5rVGkOgn/UWK0uCMB4Bo9jzviZ0XB7ombnNG 2A7O/iXlU8grGsUlCzoEYt6CVwcsRBEjVCl+Vdht2Nls86hRgCgxUEHAScct+mLny1kiDlISi 0St75J9tXblUkkJ9F86vm+c2K496KiriX8hd599LpQYS6Q9R9JO5yd5xnvgI1etRqPYhe1MFC z8agWLzpy9yroQY/WG0wtFjSPpe6u56mb0HO2eEyNfToD+cWON+u91ODxkLy96/InxnH2Ffv7 wDpKcOgsQnfAtVXL4YAnlgzkDm1JtwLYvyFc/du7fh4VkAug7RYIuEVSgY20+B8F4Y78RiSgv f1fHADWDyZ07adzaajCEoMuxYNmuCauDi268/9DPt7BUlQf7+EFzsS0bmnMZ5xXW7yr5QlKiB 23O+0vW2b4kmZDpsVgJdOBcWF49NZVzaGkDXxPqLeUMXzOx8hehYR9ecGN1Ok8m/Oqv/6Rt+n RsWuhU5Dc8JpI+zscPlrmJ3Q7VnHxEL29w2CUvYjqiBs0u+igyP6jQdAtC2BRgfk2VfIWx4pD iIwMEEXLcIZ8wXDj7pcdxPw5XhPU+9FyboGBwTAe5pScUAwXIRrVnBpta216azzAhqSkDNYqp /1mFR0ro97vtBSyI/DkflzIlzYr/7KUrM3UXQI0+PxgFB9kqz66M1JpONeYmS8evk+ThWL0qn MV/9wdZwR9BVwiOeXXPjslrVEtUzvVQs6R+1Lf/9RKWbYVg6CqOaOTSjPPU+SPjNOoS5Sj8Cj GoJukW9vYedLaY= X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 20:04:50 -0000 Message-ID: <20220426200438.Ge2GY_HuVYkgHtA5ZuJzx5PTOlGFaOvCiDHWkE-Ne8g@z> Hi Mikael, Am 26.04.22 um 21:10 schrieb Mikael Morin: > Le 26/04/2022 =C3=A0 19:12, Mikael Morin a =C3=A9crit=C2=A0: >> Le 26/04/2022 =C3=A0 15:32, Jakub Jelinek a =C3=A9crit=C2=A0: >>> or one can repeat it like: >>> =C2=A0=C2=A0=C2=A0=C2=A0 if (DECL_P (expr) >>> =C2=A0=C2=A0=C2=A0=C2=A0&& DECL_LANG_SPECIFIC (expr) >>> =C2=A0=C2=A0=C2=A0=C2=A0&& GFC_DECL_SAVED_DESCRIPTOR (expr) >>> =C2=A0=C2=A0=C2=A0=C2=A0&& GFC_DECL_SAVED_DESCRIPTOR (expr) !=3D expr) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return non_negative_strides_array= _p (GFC_DECL_SAVED_DESCRIPTOR >>> (expr)); >> >> I think I=E2=80=99ll use that. > > Here it comes. > Regression tested again. OK? works for me. Thanks for the quick fix! Harald