public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/105138 - Bogus error when function name does not shadow an intrinsic when RESULT clause is used
Date: Tue, 5 Apr 2022 21:15:37 +0200	[thread overview]
Message-ID: <0c4a7fa6-c846-09d1-d6fd-e048e44736ca@netcologne.de> (raw)
In-Reply-To: <trinity-ebbd7d53-5aea-4edb-9a6a-63b135187bbf-1649099076833@3c-app-gmx-bs58>

Hi Harald,

> Steve's analysis (see PR) showed that we confused the case when a
> symbol refererred to a recursive procedure which was named the same
> as an intrinsic.  The standard allows such recursive references
> (see e.g. F2018:19.3.1).
> 
> The attached patch is based on Steve's, but handles both functions
> and subroutines.  Testcase verified with NAG and Crayftn.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
> 
> This bug is a rejects-valid, but could also lead to wrong code,
> see e.g. the PR, comment#4.  Would this qualify for a backport
> to e.g. the 11-branch?

OK for both.

Thanks for the patch!

Best regards

	Thomas

      parent reply	other threads:[~2022-04-05 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 19:04 Harald Anlauf
2022-04-05  1:12 ` Jerry D
2022-04-05 19:15 ` Thomas Koenig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c4a7fa6-c846-09d1-d6fd-e048e44736ca@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).