From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 8DED4384B011; Tue, 16 Feb 2021 14:37:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8DED4384B011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: Bn4zOS1qZkq96HRJaOfhY/Zhj0NZm52O0z6HT028Utch6t8xA++RwueExtv74seZESUhXqDgkH ro8SuD8loxFwerqy4EYFHJKSxeDwaXl4b3y3cZM1g6JERURV/kH2CtnCVIqCTIZA/xl2TQGW6r QoUwkHN6fZ97bbFb/h3/Cy+jwjwCfRGvYSqm9Nnm10ahZ1qICHKQios0HEc78cLekbRVzeD7fm VwKax96pXxuPcv73CmURw9SMGjpnOqeN5Gcg1bADWWmjYc2PYqXXCsy6CQpctWbCA+8bkpmtta 02w= X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="58143610" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 16 Feb 2021 06:37:08 -0800 IronPort-SDR: ojYrDkWaAaJSUXB48sYfQWpC5eLwXMut/qzr5VQkrhsN9Ol/LL3qimuC/Tbg5QrjWbXvQBN2Qi 3yVo3xwVqKI7IcusrKeqUxlRMqYxpJayofU1OqwcdjB8WMy/sQhduGoc+10GmP3fKAHxNta79n nNnU4UzjS1hadcgiiViQoEqqRbhTRmPLZkb2zDPiwSTrN3/C1mxvLP3nTU+QcdwQSF5uLw+l8G miZkHItjJhXVPTmk5AfdcWyi/bFwAWpJIqQu/4FN/2fhipD5KYFXqxtevs7apULs+Q4j6H3CD7 WTg= Subject: =?UTF-8?B?KnBpbmcqIOKAkyBSZTogW1BhdGNoXSBGb3J0cmFuOiAlcmUvJWltIGZp?= =?UTF-8?Q?xes_for_OpenMP/OpenACC_+_gfc=5fis=5fsimplify=5fcontiguous?= From: Tobias Burnus To: Thomas Schwinge , , , Jakub Jelinek References: <87wnvhfuci.fsf@euler.schwinge.homeip.net> Message-ID: <0cb6d2b6-7194-323d-440b-ebbb55ef977e@codesourcery.com> Date: Tue, 16 Feb 2021 15:37:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 14:37:11 -0000 *PING* this avoids an ICE in gfc_is_simplify_contiguous, which can be at least triggered with OpenMP/OpenACC. For %re/%im it outputs a nicer error than an ICE or misleading message. [Whether %re may be used is still unclear, recently opened OpenMP + OpenACC spec issues still have to be discussed.] Tobias On 09.02.21 12:41, Tobias Burnus wrote: > Hi Thomas, hi all > > Updated patch. Changes: Testcases split + updated/extended. > OK for mainline? > > Regarding the comments: > > On 09.02.21 10:45, Thomas Schwinge wrote: >> Thanks for filing/locating these discussion items for OpenACC/OpenMP >> upstream. May also put these references into the testcases, so that >> once >> these get addressed, we have something to 'grep' for in GCC? > > Actually, they are already in the file. Alternative is to add them as > link, but I am not sure that's better. (I moved them now to the top.) > >> I note that 'zz' variants (see below) are not being checked for OpenMP > > I have now added them; I had them before but as many checks triggered, > I thought the tests were not really worthwhile. > >>> +!$acc update self(zz%re) >>> +!$acc update self(zz%im) >>> +end >> And for OpenACC, the 'zz' variants do not emit this error message here. >> (That's not immediately obvious to me.) > > Answer: 'git add' missing. The reason is that with and without > Julian's patch, the error message is different. Without his patch, > the error is: > !$acc update self(zz%re) ! { dg-error "not a proper array section" } > >> I can see how data mapping of '[...]%re' etc. are problematic (we're >> constructing an "incomplete object"?), but 'update' etc. I'd have >> expected to work: would just copy the respective "part". > Granted. The array(:)%re access might update too much, but that's not > different to array with strides or with contiguous arrays sections > which contain component reference (and more than one component). > > But that's more a question for the spec committee =E2=80=93 if it is supp= osed > to work, the code needs to be updated. > > Tobias > > > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf