From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id A57AB3858D1E; Fri, 28 Jan 2022 09:27:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A57AB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 0S44Fbf3KLYVoBvFQJHnGC43S9jiWlvOKHNwzTk0L/I6r+BjxPgC7ihy5tJXW7nSuBLQme0zLX X6TRx4i+PM+3ArFi5VH0HXL8k9kepLdsGfwgkvONYoZZrjtb1coBYVtHgudfb/Bdl179csS2qG jBKx6MDr4YbSmtC9MCkRyJtqa8Gw4tULawHAOU1jPOHN+rknnyJiiNQa1AJxxG6AuQExj91Cb5 d1cjobzDbzbSmvE5FGIvKnhP188MBOaKebUn/xonurjTj62fAQNjOZd+ckltCkYQdgoHCgO16y GzQrZi61/qcOcrcDBUZftySy X-IronPort-AV: E=Sophos;i="5.88,323,1635235200"; d="scan'208";a="73866343" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 28 Jan 2022 01:27:38 -0800 IronPort-SDR: 8zkKfNUNciLgrwALK1HbuAznTHppJ0izFuAAJ3VgCtgzbnGRQMc8ZHUsKy89wvy6Z1BTpTZtiH mXVl9xbyFoWHUNWZA2na/XAsrQdKSSdBDiThFgLe3P5wTDdj+PgDoBlnkcQhN0Sl2fjlRq3zR/ oISlJFNfz4Cz95bHUg0My/q5z1P8aNyJud2ZZC0qNnfOHpp1bvy7k8DL3FN54E5rZGkh36jrBV F4lDBS/Y7D7n7Gm8YEztquVOQG40Ng8XHYU0f++BhBJh2ThQH4KiKNyXanlCRczh742VZFHgxv FGA= Message-ID: <0ccb632a-af49-1fb6-3bce-f055690d1c68@codesourcery.com> Date: Fri, 28 Jan 2022 10:27:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [Submitted, PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Content-Language: en-US To: Andre Vehreschild , Fortran , Harald Anlauf CC: Damian Rouson , References: <20220125173213.1265f8e3@vepi2> <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> <20220128100720.4128c9ce@vepi2> From: Tobias Burnus In-Reply-To: <20220128100720.4128c9ce@vepi2> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 09:27:41 -0000 Hi Andre, your patch breaks bootstrapping: ../../repos/gcc/gcc/fortran/trans-array.cc: In function =E2=80=98tree_node*= structure_alloc_comps(gfc_symbol*, tree, tree, int, int, int, gfc_co_subro= utines_args*)=E2=80=99: ../../repos/gcc/gcc/fortran/trans-array.cc:9200:42: error: =E2=80=98cdesc= =E2=80=99 may be used uninitialized [-Werror=3Dmaybe-uninitialized] 9200 | gfc_conv_descriptor_data_set (&tmpblock, cdesc, comp); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ ../../repos/gcc/gcc/fortran/trans-array.cc:9082:16: note: =E2=80=98cdesc=E2= =80=99 was declared here 9082 | tree cdesc; | ^~~~~ cc1plus: all warnings being treated as errors make[3]: *** [Makefile:1143: fortran/trans-array.o] Error 1 Tobias On 28.01.22 10:07, Andre Vehreschild via Fortran wrote: > Hi Harald, > > thanks for the fast review. I have submitted as c9c48ab7bad. > > Will wait for two weeks (reminder set :-)) before backporting to gcc-11. > > Thank you and regards, > Andre > > On Tue, 25 Jan 2022 22:30:22 +0100 > Harald Anlauf via Fortran wrote: > >> Hi Andre', >> >> Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: >>> Hi all, >>> >>> attached patch fixes wrong code generation when broadcasting a derived = type >>> containing allocatable and non-allocatable scalars. Furthermore does it >>> prevent broadcasting of coarray-tokens, which are always local this_ima= ge. >>> Thus having them on a different image makes no sense. >>> >>> Bootstrapped and regtested ok on x86_64-linux/F35. >>> >>> Ok, for trunk and backport to 12 and 11-branch after decent time? >>> >>> I perceived that 12 is closed for this kind of bugfix, therefore asking= ok >>> for 13. >> I do not think that 12 is closed for bugfixing, especially not for >> fortran. And if my cursory reading of the patch is not misleading, >> the impact of the patch is really limited to coarrays. >> >> You may want to wait for another 1-2 days for additional comments. >> If not, it is OK from my side. >> >> Thanks for the patch! >> >> Harald >> >>> Regards, >>> Andre >>> -- >>> Andre Vehreschild * Email: vehre ad gmx dot de >> > > -- > Andre Vehreschild * Email: vehre ad gmx dot de ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955