From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 8A93A38555A4; Thu, 12 Jan 2023 12:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A93A38555A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="93066200" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 12 Jan 2023 04:24:18 -0800 IronPort-SDR: ESMLCXigMk/VhI7YT8Fm5lXp2OqWkitk3b9WfceLWqvL8xnI62BXFR16fzOEdnC1mo1zBUefa6 oIWL3XbgY7lnl+h4XE8bU2wbryqdC5VwDjm08wiVaHqjt5V1B27kbp8dQ/TFLHl7ak8ew1ZWp1 m4D/fUpPycu08Un15i8i8lU6nXFFe7TlbwSTMA2Cb2QXGIadhRfvJW1kl7XWn2A0yt+4HxDhC9 1gljxD2o2kNkmEY6dw35I9Eg0+bhV9rG9lJlvfYCgW1Go8gxeQyOI1LJROXlUcQgq5yvrql8aR woI= Message-ID: <0ceb0a87-4a7b-91ab-a259-870b63c3d847@codesourcery.com> Date: Thu, 12 Jan 2023 13:24:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Patch] Fortran/OpenMP: Reject non-scalar 'holds' expr in 'omp assume(s)' [PR107706] (was: [PR107424]) Content-Language: en-US To: Jakub Jelinek CC: gcc-patches , fortran References: <6cd99975-646d-a122-d844-c194dce8dbd0@codesourcery.com> From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: First, I messed up the PR number =E2=80=93 it should be PR107706. On 12.01.23 11:39, Jakub Jelinek wrote: > On Thu, Jan 12, 2023 at 11:22:40AM +0100, Tobias Burnus wrote: >> Rather obvious fix for that ICE. >> >> Comments? If there are none, I will commit it later as obvious. > I think the spec should be clarified, unlike clauses like if, novariants, > nocontext, indirect, final clause operands where we specify the argument > to be expression of logical type and glossary term says that OpenMP logic= al > expression [...] But for the holds clause, all we say is that holds claus= e > isn't inarguable and [...] that the listed expression evaluates to true i= n > the assumption scope. [...] > so I think making it clear that holds argument is expression of logical t= ype > would be useful. Actually, the spec does have (internally) hold-expr =3D "OpenMP logical expression" in a JSON file but that does not show up in the generated PDF. I have now filed an OpenMP spec issue for it (#3453). > That said, the patch is ok, a rank > 1 expression can't be considered to > evaluate to true... Thanks! Committed as r13-5118-g2ce55247a8bf32985a96ed63a7a92d36746723dc (with the fixed PR number). Thanks. ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955